meshkit
meshkit copied to clipboard
Rename `design.meshmodel.io` to `id.design.meshery.io`.
@MUzairS15 this is to be `design.meshery.io`, right?
Originally posted by @leecalcote in https://github.com/meshery/meshkit/pull/468#discussion_r1515553022
The renaming of the annotation will impact UI clients. The changes must be coordinated with the affected UI clients.
I want to work on this. Is anyone currently working on this @leecalcote? Also can you explain a bit about this.
Thank you @AllenOps08. 👏
@AllenOps08 here is a bit of background about the purpose of this annotation - Greenfield: Tracking newly created resources.
Ideally, a PR that you open on this repo with a change is conjoined by a PR opened on meshery/meshery
for a Docs update to that page, too.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@leecalcote Please assign this issue to me, I want to work.
@leecalcote i would like to work on this .
@leecalcote , I’ve implemented the changes in meshkit, and all the test cases are passing. Is there anything else I need to do before moving forward with the pull request?
@akshansh-modi that's good to hear. I suspect that we won't know until you open a PR.
One item to verify is that when this change is made, you can still deploy a design, and have it's "Open in Vizualizer" link work. You'll likely need the help of another maintainer to confirm this. You can call it out in your open PR.
ok @leecalcote
Completed