meshkit icon indicating copy to clipboard operation
meshkit copied to clipboard

Rename `design.meshmodel.io` to `id.design.meshery.io`.

Open MUzairS15 opened this issue 11 months ago • 10 comments

          @MUzairS15 this is to be `design.meshery.io`, right?

Originally posted by @leecalcote in https://github.com/meshery/meshkit/pull/468#discussion_r1515553022

The renaming of the annotation will impact UI clients. The changes must be coordinated with the affected UI clients.

MUzairS15 avatar Mar 07 '24 17:03 MUzairS15

I want to work on this. Is anyone currently working on this @leecalcote? Also can you explain a bit about this.

AllenOps08 avatar Mar 11 '24 08:03 AllenOps08

Thank you @AllenOps08. 👏

leecalcote avatar Mar 15 '24 21:03 leecalcote

@AllenOps08 here is a bit of background about the purpose of this annotation - Greenfield: Tracking newly created resources.

Ideally, a PR that you open on this repo with a change is conjoined by a PR opened on meshery/meshery for a Docs update to that page, too.

leecalcote avatar Mar 15 '24 21:03 leecalcote

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 02 '24 02:05 stale[bot]

@leecalcote Please assign this issue to me, I want to work.

ayushrakesh avatar Jun 27 '24 16:06 ayushrakesh

@leecalcote i would like to work on this .

akshansh-modi avatar Jul 30 '24 03:07 akshansh-modi

@leecalcote , I’ve implemented the changes in meshkit, and all the test cases are passing. Is there anything else I need to do before moving forward with the pull request?

akshansh-modi avatar Jul 30 '24 13:07 akshansh-modi

@akshansh-modi that's good to hear. I suspect that we won't know until you open a PR.

leecalcote avatar Jul 30 '24 15:07 leecalcote

One item to verify is that when this change is made, you can still deploy a design, and have it's "Open in Vizualizer" link work. You'll likely need the help of another maintainer to confirm this. You can call it out in your open PR.

leecalcote avatar Jul 30 '24 15:07 leecalcote

ok @leecalcote

akshansh-modi avatar Jul 30 '24 17:07 akshansh-modi

Completed

MUzairS15 avatar Aug 25 '24 12:08 MUzairS15