meshery icon indicating copy to clipboard operation
meshery copied to clipboard

[Mesheryctl] Lint check failures

Open leecalcote opened this issue 1 year ago • 12 comments

          Thanks, @Althaf66. See the [failed check annotations](https://github.com/meshery/meshery/actions/runs/7384544622/job/20087775484?pr=9811)? Fixing these would be a great next step for you.

Originally posted by @leecalcote in https://github.com/meshery/meshery/issues/9811#issuecomment-1874336014

leecalcote avatar Jan 03 '24 05:01 leecalcote

@Althaf66 or @yash37158?

leecalcote avatar Jan 03 '24 05:01 leecalcote

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jan 03 '24 05:01 github-actions[bot]

I'll do that @leecalcote

yash37158 avatar Jan 03 '24 06:01 yash37158

Hi @yash37158 , I also like to contribute on this issue. If you don't mind, we can contribute together.

Althaf66 avatar Jan 03 '24 08:01 Althaf66

Hey @Althaf66, do you have an update on this issue?

yash37158 avatar Jan 05 '24 18:01 yash37158

Yes. Test case were failed in this merged PR - https://github.com/meshery/meshery/pull/9815

Althaf66 avatar Jan 05 '24 21:01 Althaf66

And there is a issue in model_test.go

Althaf66 avatar Jan 06 '24 06:01 Althaf66

Your update, @yash37158?

leecalcote avatar Jan 06 '24 09:01 leecalcote

Im half way through, I'll create the PR soon

yash37158 avatar Jan 06 '24 09:01 yash37158

Oh, very good. 🙂

leecalcote avatar Jan 06 '24 09:01 leecalcote

This issue has been open for some time with no recent activity, unassigning to open it up for new contributors to give it a go.

saurabh100ni avatar Feb 01 '24 16:02 saurabh100ni

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 23 '24 01:04 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar May 06 '24 00:05 stale[bot]

I’ll let this stay closed. Issue abandoned by the contributors mentioned.

leecalcote avatar May 06 '24 02:05 leecalcote