meshery icon indicating copy to clipboard operation
meshery copied to clipboard

Add Sistent components using `Sistent Theme Provider`

Open sudhanshutech opened this issue 1 year ago • 6 comments

Notes for Reviewers

This PR fixes # Adding sistent components using testing sistent theme provider

Signed commits

  • [ ] Yes, I signed my commits.

sudhanshutech avatar Dec 21 '23 06:12 sudhanshutech

@nebula-aac While using themeprovider for only now checkbox, light mode is prefect but dark mode is having issues👇

https://github.com/meshery/meshery/assets/90546692/b4edbbf4-1b15-495f-a5c7-34be08304c68

sudhanshutech avatar Dec 21 '23 11:12 sudhanshutech

This is expected because in some places, we're using Paper which probably has its own custom styles, and divs that has its inline styles but won't probably be changes because it is not a MUI component. Thanks for bringing this up. I'll continue working on creating custom styled components to assist with migrating.

nebula-aac avatar Dec 21 '23 14:12 nebula-aac

@sudhanshutech @nebula-aac progress?

leecalcote avatar Jan 12 '24 14:01 leecalcote

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 22 '24 00:02 stale[bot]

We're starting month number 3 of the year after this was opened.

@nebula-aac can you lead the way here?

leecalcote avatar Feb 24 '24 01:02 leecalcote

Sure I will take a look when I can this week. @leecalcote

nebula-aac avatar Feb 26 '24 01:02 nebula-aac

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 11 '24 00:04 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Apr 22 '24 03:04 stale[bot]