meshery icon indicating copy to clipboard operation
meshery copied to clipboard

[mesheryctl] Lifecycle management for `meshery-nighthawk`

Open piyushsingariya opened this issue 4 years ago • 5 comments

Desired Behavior

Lifecycle commands for meshery-nighthawk container is required as subcommand under mesheryctl perf

  • perf start will start meshery-perf container in docker/kubernetes and add an entry for the container in meshconfig
    • Flag required to skip adding entry in meshconfig
  • perf stop will stop meshery-perf container in docker/kubernetes

The system start and system stop are good examples for references.

Attaching Nighthawk as a Meshery Component

Integration Tests Required

Integration Tests must be written to test the respective commands' behavior.

Mockups


Contributor Resources

piyushsingariya avatar Jan 07 '22 16:01 piyushsingariya

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jan 07 '22 16:01 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 16 '22 17:02 stale[bot]

@piyushsingariya Can I try on this?

MUzairS15 avatar Mar 10 '22 09:03 MUzairS15

@piyushsingariya @leecalcote I was thinking of picking up this issue and thought of a possible fix please let me know any changes that I need to make to my approach

The meshery-perf should be added as a service to the meshey.yaml docker-compose file and all the existing meshery containers need to be restarted when the command mesheryctl perf start command is run for the platform docker, right? I am currently looking into a solution for kubernetes platform(by creating a helm chart), would love to hear your thoughts about this.

deepakdinesh1123 avatar Dec 17 '22 03:12 deepakdinesh1123

// I will continue on this

Freedisch avatar Aug 19 '23 23:08 Freedisch