[mesheryctl] Lifecycle management for `meshery-nighthawk`
Desired Behavior
Lifecycle commands for meshery-nighthawk container is required as subcommand under mesheryctl perf
-
perf startwill startmeshery-perfcontainer in docker/kubernetes and add an entry for the container inmeshconfig- Flag required to skip adding entry in meshconfig
-
perf stopwill stopmeshery-perfcontainer in docker/kubernetes
The system start and system stop are good examples for references.
Attaching Nighthawk as a Meshery Component
Integration Tests Required
Integration Tests must be written to test the respective commands' behavior.
Mockups
Contributor Resources
This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.
Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@piyushsingariya Can I try on this?
@piyushsingariya @leecalcote I was thinking of picking up this issue and thought of a possible fix please let me know any changes that I need to make to my approach
The meshery-perf should be added as a service to the meshey.yaml docker-compose file and all the existing meshery containers need to be restarted when the command mesheryctl perf start command is run for the platform docker, right? I am currently looking into a solution for kubernetes platform(by creating a helm chart), would love to hear your thoughts about this.
// I will continue on this