meshery
add fix for model search command
Notes for Reviewers
This PR fixes #11319
- [x] Yes, I signed my commits.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@EleisonC Let's discuss this issue during the Meshery dev meeting call. Please add it as an agenda item to the meeting minutes.
It's fixed but if there are multiple models with same name you should give a prompt by adding other details of the model like version, id and on the basis of it user should select a model and then you show the model data.
Other than that this pr looks good. If you can add the above mentioned enhancement it would be very helpful.
It's fixed but if there are multiple models with same name you should give a prompt by adding other details of the model like version, id and on the basis of it user should select a model and then you show the model data.
Other than that this pr looks good. If you can add the above mentioned enhancement it would be very helpful.
I will implement it and I will reach out when done. However, I have a question: should the search command receive more than just a name or display name? For example, would it be beneficial to include parameters like version and ID? For instance, mesheryctl model search [query-text] [version] [id]. @Jougan-0
It's fixed but if there are multiple models with same name you should give a prompt by adding other details of the model like version, id and on the basis of it user should select a model and then you show the model data. Other than that this pr looks good. If you can add the above mentioned enhancement it would be very helpful.
I will implement it and I will reach out when done. However, I have a question: should the search command receive more than just a name or display name? For example, would it be beneficial to include parameters like version and ID? For instance,
mesheryctl model search [query-text] [version] [id]. @Jougan-0
Nope using the [query-text] is just fine. I was talking about when we display the data to the user on terminal we can show them more information and a prompt to choose for different model and once the model is selected then show the model data by unmarshalling the response in v1beta1.Model .
Hey @leecalcote @Ashparshp Sorry been sick. So, the task is done but there was a suggestion here. Is it possible to have this PR merged and then I go on to implement the rest of the suggestion in another PR?
Hey @leecalcote @Ashparshp Sorry been sick. So, the task is done but there was a suggestion here. Is it possible to have this PR merged and then I go on to implement the rest of the suggestion in another PR?
@Jougan-0, your guidance here is appreciated.
@EleisonC Yes we can merge this and if you would could you open a new issue and track your progress there. Whenever you see this message create an issue ping me. I'll assign that issue to you and then merge this PR.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:
@EleisonC Yes we can merge this and if you would could you open a new issue and track your progress there. Whenever you see this message create an issue ping me. I'll assign that issue to you and then merge this PR.
@EleisonC is there a separate issue opened to track this?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.