meshery icon indicating copy to clipboard operation
meshery copied to clipboard

fix: connections commands description fixed w/signoff

Open rahulrana701 opened this issue 1 year ago • 8 comments

Notes for Reviewers

This PR fixes #11311 here is the attached ss of the changes I made

Screenshot 2024-07-11 135056

Signed commits

  • [X] Yes, I signed my commits.

rahulrana701 avatar Jul 11 '24 08:07 rahulrana701

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

welcome[bot] avatar Jul 11 '24 08:07 welcome[bot]

🚀 Preview for commit 430f4a65fa05706bd73548814a1ab712f656d7c1 at: https://668f9ce39a833618143b8bd3--meshery-docs-preview.netlify.app

l5io avatar Jul 11 '24 08:07 l5io

@rahulrana701 Could we discuss this issue during the Meshery dev meeting call? Please add it as an agenda item to the meeting minutes.

ashparshp avatar Jul 16 '24 05:07 ashparshp

@rahulrana701 could you fix lint error please

lekaf974 avatar Jul 22 '24 22:07 lekaf974

@rahulrana701 could you fix lint error please

forgot about this comment, just see that it looks not related to your changes

lekaf974 avatar Jul 22 '24 22:07 lekaf974

🚀 Preview for commit 2d7c7fee5e4ede6c1f20f124dff0fa781f05c9fc at: https://66cd9d0d215411c39bde0b8c--meshery-docs-preview.netlify.app

l5io avatar Aug 27 '24 09:08 l5io

@Ashparshp, sorry for the delay. All the checks have successfully passed, and this branch is good to go.

rahulrana701 avatar Aug 27 '24 09:08 rahulrana701