meshery
meshery copied to clipboard
Add connection view implementation
Notes for Reviewers
This PR fixes (#10582) replaced by #10965
- [X] Yes, I signed my commits.
@hexxdump look good?
@hexxdump look good?
yes, looks good, just had some typos, pointed it out.
Codecov Report
Attention: Patch coverage is 0%
with 36 lines
in your changes are missing coverage. Please review.
Project coverage is 9.13%. Comparing base (
17acf25
) to head (91b8500
). Report is 78 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
mesheryctl/pkg/utils/error.go | 0.00% | 18 Missing :warning: |
server/handlers/connections_handlers.go | 0.00% | 18 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #10916 +/- ##
==========================================
+ Coverage 9.00% 9.13% +0.12%
==========================================
Files 146 146
Lines 19274 19279 +5
==========================================
+ Hits 1736 1761 +25
+ Misses 17236 17216 -20
Partials 302 302
Flag | Coverage Δ | |
---|---|---|
unittests | 9.13% <0.00%> (+0.12%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you, @hexxdump 👏
@Jougan-0 do you mind giving this a once-over?
@MUzairS15 you were going to do changes in connection_handler replace /api/integrations/connections/{connectionKind}
by /api/integrations/connections/{connectionId}
, am I right ?
Yes I will be and your PR is complete already from your side
Uh-oh, a couple of merge conflicts have bubbled up.
@singh1203 or @Jougan-0 will you assist in seeing these merge conflicts eliminated and this PR merged?
We haven't heard from @lekaf974 recently, so please tie this off on his behalf.
Closing this as I am tying this off in #11490