meshery icon indicating copy to clipboard operation
meshery copied to clipboard

Add connection view implementation

Open lekaf974 opened this issue 9 months ago • 9 comments

Notes for Reviewers

This PR fixes (#10582) replaced by #10965

Signed commits

  • [X] Yes, I signed my commits.

lekaf974 avatar May 10 '24 02:05 lekaf974

github-actions[bot] avatar May 10 '24 02:05 github-actions[bot]

@hexxdump look good?

leecalcote avatar May 16 '24 15:05 leecalcote

@hexxdump look good?

yes, looks good, just had some typos, pointed it out.

hexxdump avatar May 17 '24 03:05 hexxdump

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 9.13%. Comparing base (17acf25) to head (91b8500). Report is 78 commits behind head on master.

Files Patch % Lines
mesheryctl/pkg/utils/error.go 0.00% 18 Missing :warning:
server/handlers/connections_handlers.go 0.00% 18 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10916      +/-   ##
==========================================
+ Coverage    9.00%    9.13%   +0.12%     
==========================================
  Files         146      146              
  Lines       19274    19279       +5     
==========================================
+ Hits         1736     1761      +25     
+ Misses      17236    17216      -20     
  Partials      302      302              
Flag Coverage Δ
unittests 9.13% <0.00%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 21 '24 22:05 codecov[bot]

Thank you, @hexxdump 👏

leecalcote avatar May 29 '24 22:05 leecalcote

@Jougan-0 do you mind giving this a once-over?

leecalcote avatar May 29 '24 22:05 leecalcote

@MUzairS15 you were going to do changes in connection_handler replace /api/integrations/connections/{connectionKind} by /api/integrations/connections/{connectionId}, am I right ?

lekaf974 avatar May 30 '24 01:05 lekaf974

Yes I will be and your PR is complete already from your side

MUzairS15 avatar May 30 '24 07:05 MUzairS15

Uh-oh, a couple of merge conflicts have bubbled up.

leecalcote avatar Jul 01 '24 21:07 leecalcote

@singh1203 or @Jougan-0 will you assist in seeing these merge conflicts eliminated and this PR merged?

We haven't heard from @lekaf974 recently, so please tie this off on his behalf.

leecalcote avatar Jul 11 '24 21:07 leecalcote

Closing this as I am tying this off in #11490 

singh1203 avatar Jul 30 '24 10:07 singh1203