meshery icon indicating copy to clipboard operation
meshery copied to clipboard

[RTK] Migrate User component to rtk

Open dottharun opened this issue 1 year ago • 8 comments
trafficstars

Notes for Reviewers

This PR is related to #9985

  • [x] replaced dataFetch calls with rtk-query calls
  • [x] added error logs for rtk-query hooks
  • [x] removed useEffects with useState logic when needed

Signed commits

  • [x] Yes, I signed my commits.

dottharun avatar Feb 11 '24 18:02 dottharun

github-actions[bot] avatar Feb 11 '24 18:02 github-actions[bot]

@sudhanshutech made the commit with changes, this should be enough i think

dottharun avatar Feb 12 '24 17:02 dottharun

Hi @dottharun Thanks for your PR! I encourage you to share this in the Meshery Development Meeting tomorrow at 8:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.

You're welcome at the meeting

Check to community calendar for more details of meetings at Layers.

saurabh100ni avatar Feb 13 '24 14:02 saurabh100ni

@dottharun you can take reference form connection/index.js in fetching environment , how error prop is used https://github.com/meshery/meshery/blob/master/ui/components/connections/index.js#L209

sudhanshutech avatar Feb 14 '24 04:02 sudhanshutech

@dottharun have you updated the spreadsheet linked to the issue. Otherwise look good please use the error prop from rtk. tagging @aabidsofi19 @Yashsharma1911 they can merge when you done

sudhanshutech avatar Feb 14 '24 06:02 sudhanshutech

@sudhanshutech commited the changes

dottharun avatar Feb 16 '24 04:02 dottharun

@aabidsofi19 commits with changes are done

dottharun avatar Feb 17 '24 21:02 dottharun

@aabidsofi19 commits with changes are done

Thanks, @dottharun 👍

leecalcote avatar Feb 24 '24 01:02 leecalcote

@dottharun are you there? What's the status here

sudhanshutech avatar Mar 26 '24 18:03 sudhanshutech

@dottharun are you there? What's the status here

Nothing more to do i guess

dottharun avatar Mar 26 '24 18:03 dottharun

@dottharun there are few other PRs raised by other contributors on RTK migration, maybe you would like to help by reviewing them?

Yashsharma1911 avatar Mar 27 '24 13:03 Yashsharma1911

Please show this update in todays Meshery Dev Meeting if you didn't already

Yashsharma1911 avatar Mar 27 '24 13:03 Yashsharma1911