meshery
meshery copied to clipboard
[RTK] Migrate User component to rtk
Notes for Reviewers
This PR is related to #9985
- [x] replaced dataFetch calls with rtk-query calls
- [x] added error logs for rtk-query hooks
- [x] removed useEffects with useState logic when needed
- [x] Yes, I signed my commits.
@sudhanshutech made the commit with changes, this should be enough i think
Hi @dottharun Thanks for your PR! I encourage you to share this in the Meshery Development Meeting tomorrow at 8:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.
You're welcome at the meeting
Check to community calendar for more details of meetings at Layers.
@dottharun you can take reference form connection/index.js in fetching environment , how error prop is used
https://github.com/meshery/meshery/blob/master/ui/components/connections/index.js#L209
@dottharun have you updated the spreadsheet linked to the issue. Otherwise look good please use the error prop from rtk. tagging @aabidsofi19 @Yashsharma1911 they can merge when you done
@sudhanshutech commited the changes
@aabidsofi19 commits with changes are done
@aabidsofi19 commits with changes are done
Thanks, @dottharun 👍
@dottharun are you there? What's the status here
@dottharun are you there? What's the status here
Nothing more to do i guess
@dottharun there are few other PRs raised by other contributors on RTK migration, maybe you would like to help by reviewing them?
Please show this update in todays Meshery Dev Meeting if you didn't already
