meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

Website: Consolidate duplicative and unused CSS

Open leecalcote opened this issue 2 years ago β€’ 19 comments

Current Behavior This site has much unused CSS and some overlapping CSS.

Desired Behavior Use of SASS is preferred. Ideally, most of the CSS (by line count) is removed from the site. This can be done piecemeal over multiple PRs.


Contributor Guides and Resources

leecalcote avatar Nov 03 '22 21:11 leecalcote

Hey @leecalcote, I can work on this. Can you please explain what you mean by multiple PRs?

tinniaru3005 avatar Nov 06 '22 21:11 tinniaru3005

@tinniaru3005 this effort doesn't have to be completed in one shot.

leecalcote avatar Nov 06 '22 21:11 leecalcote

@tinniaru3005 does this make sense?

leecalcote avatar Nov 16 '22 05:11 leecalcote

@tinniaru3005 does this make sense?

Ya, it does. Should I get started with solving it? Is there any specification on breaking up the task that I should follow?

tinniaru3005 avatar Nov 17 '22 08:11 tinniaru3005

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 17 '22 19:12 stale[bot]

Hey @leecalcote can i take this task ?

arun-kushwaha04 avatar Jan 21 '23 19:01 arun-kushwaha04

Thanks, @arun-kushwaha04

leecalcote avatar Jan 21 '23 19:01 leecalcote

@leecalcote Let me try this one now

ashutosh887 avatar Mar 19 '23 18:03 ashutosh887

Thanks @leecalcote

ashutosh887 avatar Apr 25 '23 17:04 ashutosh887

@ashutosh887 please update

DarrenDsouza7273 avatar May 11 '23 14:05 DarrenDsouza7273

is the issue solved or anyone is working on it?

Pranjal7852 avatar May 23 '23 13:05 Pranjal7852

@Pranjal7852 theres been no updates from @ashutosh887 so i guess he might be working on it

DarrenDsouza7273 avatar May 23 '23 13:05 DarrenDsouza7273

I already have some experience in Sass architecture , and upon looking at the repo i found the basic architecture missing as mentioned in https://sass-guidelin.es/#architecture , the 7-1 pattern Basically, we have all our partials stuffed into 7 different folders, and a single file at the root level (usually named main.scss) which imports them all to be compiled into a CSS stylesheet.

base/ components/ layout/ pages/ themes/ abstracts/ vendors/

Ghat0tkach avatar May 27 '23 05:05 Ghat0tkach

@Pranjal7852 do you still want to work on this issue or let @Ghat0tkach take up this issue?

Savio629 avatar Jun 02 '23 17:06 Savio629

I still working on this issue @Savio629 cheers

Pranjal7852 avatar Jun 03 '23 15:06 Pranjal7852

@Pranjal7852, since we haven't heard back from @Pranjal7852, Reassigning this issue to myself

thisiskaransgit avatar Jul 25 '23 21:07 thisiskaransgit

@sudhanshutech Can I assign myself this issue?

Dananjay996 avatar Nov 27 '23 14:11 Dananjay996

Hey @leecalcote ! if this issue is still open would like to work on it.

THEBOSS0369 avatar Aug 16 '24 12:08 THEBOSS0369

Hey @leecalcote ! I have added PR for this issue here https://github.com/meshery/meshery.io/pull/1880 by using this method we can easily remove unused CSS from the codebase without checking every file manually.

THEBOSS0369 avatar Aug 21 '24 12:08 THEBOSS0369