meshery.io
meshery.io copied to clipboard
meshery
Bug Fixed
Signed-off-by: Utkarsh Mishra [email protected]
Description
This PR fixes #843
Notes for Reviewers
Signed commits
- [x] Yes, I signed my commits.
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | a41e2005b6d200fbb25bb0cfcc2ac26b353b3bfa |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/63495e043c25c9000b242bf0 |
| Deploy Preview | https://deploy-preview-864--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm not able to upload the video for both before the update and after the update. So may I upload it on the drive and paste the link here? @leecalcote @legendarykamal
@UtkarshMishra12 I would suggest a change to your code.
Desc: The input box width is too small according to the width of subscribe btn (at 1229px).
Current behavior at 1229 :
Expected behavior:
@Krishna2323 Now you can check the updated size of the input field. Let me know your thoughts
Now it looks good to me and is ready to be merged. @legendarykamal @leecalcote, correct me if I am wrong.
Could you merge the master branch to your branch it seems, and also changes from @Nikhil-Ladha, other than that it looks good. 👍
@Nikhil-Ladha project mailing list buttons are being addressed in a separate issue and someone is working on it.
While subscribe button could be taken care of in this itself. // @UtkarshMishra12 .
@Nikhil-Ladha @legendarykamal @asubedy Please review it now, the changes are made to the subscribe button.