meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

Published 20 hours ago • verified publisher icon meshery

Issue #822 fixed: Navbar dropdowm multiple link selection problem.

Open Krishna2323 opened this issue 2 years ago • 9 comments

Signed-off-by: Krishna Gupta [email protected]

Description Now both can't be selected at the same time because whenever someone points the cursor to the first dropdown the pointer events of the second dropdown will be set to none.

This PR fixes #822

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

Krishna2323 avatar Oct 03 '22 07:10 Krishna2323

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit aa8608eb62a897a61695c3670ea6e8b5ce1d99c8
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6382908843091100090ff6e9
Deploy Preview https://deploy-preview-856--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 03 '22 07:10 netlify[bot]

@legendarykamal @leecalcote I think the issue was, that we can hover over multiple dropdowns at the same time. If it needs to fix for overlapping then we need to add some extra spaces between the links.

Krishna2323 avatar Oct 03 '22 20:10 Krishna2323

@legendarykamal @leecalcote I think the issue was, that we can hover over multiple dropdowns at the same time. If it needs to fix for overlapping then we need to add some extra spaces between the links.

I beg to differ. Separating with space is just a work-around the root issue and is admitting defeat on what is a relatively simple challenge.

leecalcote avatar Oct 04 '22 21:10 leecalcote

it's just a bit 'o CSS needed here.

leecalcote avatar Oct 04 '22 21:10 leecalcote

@leecalcote I thought the issue was that we can jump to the other dropdown if it was open. Is this ok? https://user-images.githubusercontent.com/85894871/193937934-b404c21f-0214-40b4-959c-41ee391ee7c7.mp4

Krishna2323 avatar Oct 04 '22 21:10 Krishna2323

@Krishna2323 yes, you're right regarding the issue. I see that, yes, in your .mp4 that while both menus are visible concurrently, they do not overlap. Yes, that'll work.

Here is the experience that I see on https://deploy-preview-856--mesheryio-preview.netlify.app/ using Safari:

https://user-images.githubusercontent.com/7570704/193938472-f641cea1-dbe5-45a2-ae6e-1f578d9c74f6.mov

Here is the experience that I see on https://deploy-preview-856--mesheryio-preview.netlify.app/ using Chrome:

https://user-images.githubusercontent.com/7570704/193938563-39e3604c-d9ea-41b8-a0ba-0c5945be8757.mov

leecalcote avatar Oct 04 '22 22:10 leecalcote

@leecalcote pls review this one.

Krishna2323 avatar Oct 08 '22 13:10 Krishna2323

@Krishna2323 will you discuss this on the websites call today?

debo19 avatar Oct 10 '22 08:10 debo19

@debo19, I think it is already fixed, PR just needs a review.

Krishna2323 avatar Oct 10 '22 10:10 Krishna2323

@debo19, I think it is already fixed, PR just needs a review.

Right. You can still demo your work on the call 😄

debo19 avatar Oct 10 '22 11:10 debo19

@Nikhil-Ladha pls review this one. I think it's fine now.

Krishna2323 avatar Oct 16 '22 10:10 Krishna2323

I am not sure what you mean when you say it's "fine now". I can still see 2 drop-downs being opened simultaneously. Though, I believe this is an issue with the closing animation that we have in the stellarnav.js script. To fix this issue, we would need to get away with the closing animation, or just avoiding overlap is the only possibility.

Let's discuss it on today's call, and we can decide on it accordingly.

Nikhil-Ladha avatar Oct 17 '22 06:10 Nikhil-Ladha

@Krishna2323 will you plan on a review of this on Monday's website call along with a final review of the initial dark mode theme?

leecalcote avatar Nov 03 '22 21:11 leecalcote