meshery.io
meshery.io copied to clipboard
meshery
Added Logo
Signed-off-by: Utkarsh Mishra [email protected]
Description Changed the Meshery logos for dark/light mode with high contrast This PR fixes #844
Notes for Reviewers
Signed commits
- [x] Yes, I signed my commits.
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | 0af18b3301d3decbde7839d210b0b741511e4c16 |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/634854d65a41c900087a0567 |
| Deploy Preview | https://deploy-preview-846--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@leecalcote Yes, the code I have used is taken from the README.md of Meshery Repo as suggested by Kamal in other issue also link
Will you please confirm that this is the same code (verbatim) of the other readmes in the repos in the
Mesheryorg?
although this creates a dependency that the image should be there in main meshery/meshery repo with using this https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-dark-text-side.svg but @leecalcote that seems fair to me as it is our main repo and we don't have to manually add the same logo to each repo.
Will you please confirm that this is the same code (verbatim) of the other readmes in the repos in the
Mesheryorg?although this creates a dependency that the image should be there in main meshery/meshery repo with using this https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-dark-text-side.svg but @leecalcote that seems fair to me as it is our main repo and we don't have to manually add the same logo to each repo.
@legendarykamal you're right. I neglected to be more precise that the desire is for images to be locally referenced (as they are stored in each repo), but that the rest of the html/markdown was to be identical. Ideally, even the references are identical - - they would be if relative references were used.
Hey, @leecalcote so I have to take the Logo image from the local repo(store the media inside the repo, and refer to its path for showing it on Readme.md), not from the other repo?
yes @UtkarshMishra12 store it locally and then use relative referencing to render it.
@leecalcote @legendarykamal As per your suggestion, I have stored the logos locally and then used relative referencing to render them. Let me know your thought on it.