meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

Published 20 hours ago • verified publisher icon meshery

pagination for catalog

Open kamalbuilds opened this issue 2 years ago • 5 comments

Signed-off-by: Kamal Nayan [email protected]

Description Note- Not yet complete.

This PR fixes #732

Notes for Reviewers This is in progress to create pagination for the catalog

Signed commits

  • [x] Yes, I signed my commits.

kamalbuilds avatar Aug 28 '22 17:08 kamalbuilds

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit 065e43107c1abc49efd82a54e9d7f12190e30efb
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/630ba8ef0d02e30007e2dbb2
Deploy Preview https://deploy-preview-823--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 28 '22 17:08 netlify[bot]

@legendarykamal , this will not work because

  1. The Jekyll paginate gem which we use only works on posts, here the patterns are collection, but the blogs are posts hence we use this for paginating the blogs
  2. This approach breaks the blogs page and breaks the catalog page too

So we need a different approach here, one thing you can try is manually showing certain number of cards on one link and similarly on the other.

asubedy avatar Aug 28 '22 18:08 asubedy

@asubedy thanks for the prompt feedback, I will try that approach.

kamalbuilds avatar Aug 28 '22 18:08 kamalbuilds

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 27 '22 20:09 stale[bot]

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 28 '22 16:09 github-actions[bot]

@legendarykamal Any updates on this?

adithyaakrishna avatar Oct 23 '22 10:10 adithyaakrishna

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 22 '22 13:11 stale[bot]

after exams, I will finish this ✅

kamalbuilds avatar Nov 22 '22 15:11 kamalbuilds

@Krishna2323, in light of sweeping changes across the site, is this PR still valid (necessary)?

leecalcote avatar Nov 29 '22 16:11 leecalcote

@Krishna2323, in light of sweeping changes across the site, is this PR still valid (necessary)?

Please make a call here.

leecalcote avatar Dec 19 '22 22:12 leecalcote

@leecalcote, yes, if we don't want to show all the entries at one page. @legendarykamal any updates on this?

Krishna2323 avatar Dec 20 '22 04:12 Krishna2323

That yes is a little Ambivalent , If we don't want to show all at 1 pg . Then , we need this PR right ?

Updates , I am not in sync with what the sweeping changes are ? as reflected by @leecalcote . So , I will work on this only if its neccessary to this point of time.

kamalbuilds avatar Dec 20 '22 04:12 kamalbuilds

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 19 '23 06:01 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Jan 26 '23 06:01 stale[bot]