meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

[Ui] Made the features container section responsive

Open Rohith-Raju opened this issue 2 years ago • 17 comments

Signed-off-by: Rohith Raju [email protected]

Description Made the catalog section responsive

This PR fixes #784

Notes for Reviewers Since this Pr is yet to merge, I've yet to fix the responsiveness for the catalog section

Signed commits

  • [x] Yes, I signed my commits.

Rohith-Raju avatar Jul 27 '22 08:07 Rohith-Raju

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit f792c42300af621fdeeaed6de65db7900e335daa
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6333c8cbe566680008c63bab
Deploy Preview https://deploy-preview-787--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 27 '22 08:07 netlify[bot]

image image

Rohith-Raju avatar Jul 27 '22 08:07 Rohith-Raju

Sure @YashKamboj

Rohith-Raju avatar Jul 27 '22 11:07 Rohith-Raju

https://github.com/meshery/meshery.io/pull/767 Is merged. 👍

leecalcote avatar Aug 04 '22 05:08 leecalcote

Yep @leecalcote, Working on it.

Rohith-Raju avatar Aug 04 '22 06:08 Rohith-Raju

@leecalcote @YashKamboj Grid layout for mobile image

Rohith-Raju avatar Aug 04 '22 16:08 Rohith-Raju

@YashKamboj @leecalcote Heads up as of now cloud native catalog nav item has been removed from the drop down. links are still live though so head over to /catalog.

Rohith-Raju avatar Aug 04 '22 16:08 Rohith-Raju

@Rohith-Raju I think we're ok now:

Screen Shot 2022-08-05 at 6 21 02 PM

We do need to fix the padding / margin issue that I left wherein the on hover background color isn't covering the full width of the menu on the righthand side.

leecalcote avatar Aug 05 '22 23:08 leecalcote

We seem to still have a bit of overlap -

Screen Shot 2022-08-05 at 6 30 07 PM

leecalcote avatar Aug 05 '22 23:08 leecalcote

@Rohith-Raju I think we're ok now:

Screen Shot 2022-08-05 at 6 21 02 PM

We do need to fix the padding / margin issue that I left wherein the on hover background color isn't covering the full width of the menu on the righthand side.

@leecalcote Sure,I'll do that

Rohith-Raju avatar Aug 06 '22 02:08 Rohith-Raju

We seem to still have a bit of overlap -

Screen Shot 2022-08-05 at 6 30 07 PM

@leecalcote too many overriding styles. I'll have to change classes, gonna be here for a while

Rohith-Raju avatar Aug 06 '22 02:08 Rohith-Raju

@leecalcote @YashKamboj

Rohith-Raju avatar Aug 08 '22 07:08 Rohith-Raju

@Rohith-Raju adding a collapse button would be a great addition

YashKamboj avatar Aug 08 '22 07:08 YashKamboj

@YashKamboj I agree, But aren't we re-designing the entire meshery.io site?

Rohith-Raju avatar Aug 08 '22 07:08 Rohith-Raju

@leecalcote @YashKamboj we good ?

screen-recorder-sat-aug-13-2022-13-47-36.webm

Rohith-Raju avatar Aug 13 '22 08:08 Rohith-Raju

@Rohith-Raju load more looks great!!, Nice work!! But the feature to filter the filters not the best feature to add. A collapse button might be a better option. @debo19 views??

YashKamboj avatar Aug 13 '22 08:08 YashKamboj

Oh,ok @YashKamboj

Rohith-Raju avatar Aug 13 '22 15:08 Rohith-Raju

@YashKamboj @leecalcote something like this ?

screen-recorder-thu-aug-11-2022-21-25-55.webm

Rohith-Raju avatar Aug 19 '22 04:08 Rohith-Raju

Demo'ed on today's Websites meeting?

leecalcote avatar Aug 22 '22 20:08 leecalcote

@leecalcote I couldn't, ran outta time..

Rohith-Raju avatar Aug 23 '22 03:08 Rohith-Raju

@leecalcote, @YashKamboj now the button looks like this. image

Rohith-Raju avatar Sep 13 '22 03:09 Rohith-Raju

Ooooh, I like it! @warunicorn19 @asubedy @YashKamboj how does this strike you?

leecalcote avatar Sep 13 '22 04:09 leecalcote

@PIYUSH-MISHRA-00, thank you for reviewing this PR. What do you think of the latest, proposed filter icon / button?

leecalcote avatar Sep 13 '22 04:09 leecalcote

Looks great!

warunicorn19 avatar Sep 13 '22 07:09 warunicorn19

Ooo, nice, this one looks better 👍

asubedy avatar Sep 13 '22 13:09 asubedy

Thank you folks!!.. Do we get this merged if everything is a go?

Rohith-Raju avatar Sep 13 '22 13:09 Rohith-Raju

Merge when ready @asubedy @warunicorn19

leecalcote avatar Sep 13 '22 13:09 leecalcote

Sure @asubedy

Rohith-Raju avatar Sep 14 '22 06:09 Rohith-Raju

@asubedy could you check it now? changed it back to normal.

Rohith-Raju avatar Sep 18 '22 12:09 Rohith-Raju

Ok @warunicorn19 , on it!!

Rohith-Raju avatar Sep 22 '22 02:09 Rohith-Raju