meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

Only 9 cards are visible at a time

Open bhushan354 opened this issue 1 year ago • 6 comments

Description

This PR fixes #1852

Notes for Reviewers Earlier, all the cards were displayed at once in meshery.io/catalog page, This MR contains changes which shows only 9 cards per page.

Signed commits

  • [x] Yes, I signed my commits.

bhushan354 avatar Oct 07 '24 08:10 bhushan354

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit 4e559e2bd9cac70a83b7a5b09d77ed3a89a8001c
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/674140e967061700081d8a55
Deploy Preview https://deploy-preview-1920--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 07 '24 08:10 netlify[bot]

@bhushan354 Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

adding it as an agenda item to the meeting minutes.

vishalvivekm avatar Oct 07 '24 11:10 vishalvivekm

I have reverted the changes I have made earlier now trying to fix the exact bug

bhushan354 avatar Oct 10 '24 04:10 bhushan354

What's the bug?

hortison avatar Oct 11 '24 02:10 hortison

@bhushan354 would we be discussing updates from you on this PR today?

[!Note] Weekly websites call : https://meet.layer5.io/websites Oct 14, 2024 at 7 AM CT | 5:30 PM IST Meeting minutes: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?tab=t.0

vishalvivekm avatar Oct 14 '24 08:10 vishalvivekm

Hi @vishalvivekm , @amitamrutiya , I’ve been working on fixing the bug, but I’m unable to fully resolve it. I’d appreciate any suggestions !

bhushan354 avatar Nov 26 '24 15:11 bhushan354

@vishalvivekm @amitamrutiya For now, the deploy preview https://deploy-preview-1920--mesheryio-preview.netlify.app/ has a temporary fix. I’ve simulated a “Next” and “Previous” button click to address the issue, which resolves the bug for the time being.

bhushan354 avatar Nov 26 '24 15:11 bhushan354

Thank you Bhushan, I'm tossing a fix for this in a couple of minutes

On Tue, 26 Nov 2024, 21:12 Bhushan Deshmukh, @.***> wrote:

@vishalvivekm https://github.com/vishalvivekm @amitamrutiya https://github.com/amitamrutiya For now, the deploy preview https://deploy-preview-1920--mesheryio-preview.netlify.app/ has a temporary fix. I’ve simulated a “Next” and “Previous” button click to address the issue, which resolves the bug for the time being.

— Reply to this email directly, view it on GitHub https://github.com/meshery/meshery.io/pull/1920#issuecomment-2501200351, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2MMDZ3FTLTQROMOWEYWKIT2CSJFHAVCNFSM6AAAAABPPLKAVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRGIYDAMZVGE . You are receiving this because you were mentioned.Message ID: @.***>

vishalvivekm avatar Nov 26 '24 15:11 vishalvivekm

@bhushan354 take a look at his PR: https://github.com/meshery/meshery.io/pull/1975

vishalvivekm avatar Nov 30 '24 07:11 vishalvivekm

Thank you, @vishalvivekm , for resolving this! It looks great.

bhushan354 avatar Dec 03 '24 15:12 bhushan354