meshery.io
meshery.io copied to clipboard
Only 9 cards are visible at a time
Description
This PR fixes #1852
Notes for Reviewers Earlier, all the cards were displayed at once in meshery.io/catalog page, This MR contains changes which shows only 9 cards per page.
- [x] Yes, I signed my commits.
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | 4e559e2bd9cac70a83b7a5b09d77ed3a89a8001c |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/674140e967061700081d8a55 |
| Deploy Preview | https://deploy-preview-1920--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@bhushan354 Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).
adding it as an agenda item to the meeting minutes.
I have reverted the changes I have made earlier now trying to fix the exact bug
What's the bug?
@bhushan354 would we be discussing updates from you on this PR today?
[!Note] Weekly websites call : https://meet.layer5.io/websites Oct 14, 2024 at 7 AM CT | 5:30 PM IST Meeting minutes: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?tab=t.0
Hi @vishalvivekm , @amitamrutiya , I’ve been working on fixing the bug, but I’m unable to fully resolve it. I’d appreciate any suggestions !
@vishalvivekm @amitamrutiya For now, the deploy preview https://deploy-preview-1920--mesheryio-preview.netlify.app/ has a temporary fix. I’ve simulated a “Next” and “Previous” button click to address the issue, which resolves the bug for the time being.
Thank you Bhushan, I'm tossing a fix for this in a couple of minutes
On Tue, 26 Nov 2024, 21:12 Bhushan Deshmukh, @.***> wrote:
@vishalvivekm https://github.com/vishalvivekm @amitamrutiya https://github.com/amitamrutiya For now, the deploy preview https://deploy-preview-1920--mesheryio-preview.netlify.app/ has a temporary fix. I’ve simulated a “Next” and “Previous” button click to address the issue, which resolves the bug for the time being.
— Reply to this email directly, view it on GitHub https://github.com/meshery/meshery.io/pull/1920#issuecomment-2501200351, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2MMDZ3FTLTQROMOWEYWKIT2CSJFHAVCNFSM6AAAAABPPLKAVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRGIYDAMZVGE . You are receiving this because you were mentioned.Message ID: @.***>
@bhushan354 take a look at his PR: https://github.com/meshery/meshery.io/pull/1975
Thank you, @vishalvivekm , for resolving this! It looks great.