meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

Published 20 hours ago • verified publisher icon meshery

Enhance the icon collection for Helm plugin

Open bhushan354 opened this issue 1 year ago • 4 comments

Description

This PR fixes # https://github.com/meshery/meshery.io/issues/1915

Notes for Reviewers I have implemented the basic structure necessary to add the new extension on the meshery.io/extensions/ page. However, the content displayed in the pop-up still needs to be updated, and the light theme also requires modifications.

image

Signed commits

  • [x] Yes, I signed my commits.

bhushan354 avatar Oct 02 '24 14:10 bhushan354

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

welcome[bot] avatar Oct 02 '24 14:10 welcome[bot]

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit 1fdd6e0bb419aed2fdf9ea49c6fde729ec1e75cb
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66fd55a3743fa20008368350
Deploy Preview https://deploy-preview-1917--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 02 '24 14:10 netlify[bot]

@bhushan354 Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

vishalvivekm avatar Oct 07 '24 07:10 vishalvivekm

@bhushan354 https://github.com/meshery/meshery.io/pull/1920#issuecomment-2410368016

vishalvivekm avatar Oct 14 '24 08:10 vishalvivekm

What happens when the site visitor is using light mode?

@bhushan354?

leecalcote avatar Oct 31 '24 20:10 leecalcote

@leecalcote I’m still working on it. Also, I wanted to ask why the changes I made to the code, like the UI updates, aren't reflecting on localhost.

bhushan354 avatar Nov 01 '24 12:11 bhushan354

i am having this problem from many days

bhushan354 avatar Nov 01 '24 12:11 bhushan354

Exclude —incremental and —livereload from your build command.

leecalcote avatar Nov 01 '24 12:11 leecalcote

https://github.com/user-attachments/assets/23cf0965-2566-42d0-a6a5-ca5834861ae3

@leecalcote I've excluded --incremental and --livereload from the build command, but the issue is still persisting.

bhushan354 avatar Nov 03 '24 02:11 bhushan354

@leecalcote its working now and updating according to local changes , thanks for the help !!

bhushan354 avatar Nov 04 '24 17:11 bhushan354

@bhushan354 any updates?

sudhanshutech avatar Nov 23 '24 14:11 sudhanshutech

@sudhanshutech someone has already added the helm plugin extension https://meshery.io/extensions

bhushan354 avatar Nov 23 '24 16:11 bhushan354