meshery.io
meshery.io copied to clipboard
New PR for Unused CSS
This PR fixes #896 This is the new PR for this PR https://github.com/meshery/meshery.io/pull/1880
Description have added a script by which, now user don't have to change the file name in any file he/she just have to update the file name in the terminal.
I have added an unused component name-btn so after running this in the terminal, it will automatically delete all the unnecessary css component that is not in used. If you want to check any other file just change blog.scss to file you wanted to check anything-you-want.scss and it will done its work.
Run this in terminal
node check-unused-css.js blog.scss
This will be prompted in terminal after execution of the script
Success: The file 'blog.scss' was processed successfully. The output has been saved to './output/blog.scss' NOTE: ALL THE UNUSED CSS IS REMOVED FROM THE UPDATED FILE
Before running the script, i added an name-btn unused component in website
It is removed after execution of code
Note : The updated file will be saved in the output directory.
Notes for Reviewers I found that many of the unused css styles are the ones that are used by pressing or hovering component like a button it has many styles like hovering OR on pressing different styles is used. so its style will be unused until the component is not in used.
- [ ] Yes, I signed my commits.
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | cdaefc0bf00f55d843b7b0c2f26090c522f87e34 |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/672ee566672e41000813b2d0 |
| Deploy Preview | https://deploy-preview-1898--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@THEBOSS0369, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).
Please consider adding it as an agenda item to the meeting minutes || meeting link.
@THEBOSS0369, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).
Please consider adding it as an agenda item to the meeting minutes || meeting link.
Hey @Ashparshp ! This PR has already been discussed. Sudhanshu asked me to revert back the unnecessary changes from the previous PR and i wasn't able to revert back so i created a new One! Also the Previous Pr for this has been asked to reviewed from reviewers.
@THEBOSS0369 extraneous commits
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@sudhanshutech @SAHU-01 ! Can you take a look?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.