meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

[UI] Fix Navbar not closing on click getting started in mobile view

Open hymmns opened this issue 1 year ago • 15 comments

Description

This PR fixes #1888

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

hymmns avatar Aug 27 '24 01:08 hymmns

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

welcome[bot] avatar Aug 27 '24 01:08 welcome[bot]

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit a661d4260457bbeb2f8233b65d0bdab96f36a5ff
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6714049865baf60008ddc158
Deploy Preview https://deploy-preview-1889--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 27 '24 01:08 netlify[bot]

It would also be good to keep the animation we already have when closing the navbar menu.

amitamrutiya avatar Aug 27 '24 03:08 amitamrutiya

Ok thanks @amitamrutiya Will get on it as soon as I can

hymmns avatar Aug 27 '24 03:08 hymmns

@amitamrutiya and @sudhanshutech does this address your comments

hymmns avatar Aug 29 '24 21:08 hymmns

Whoa @hymmns, you did an excellent job! One more request: if you can figure out how to do this, could you please add a smooth scrolling effect when we press the "Getting Started" button, regardless of the screen size?

amitamrutiya avatar Aug 30 '24 07:08 amitamrutiya

I found an issue in your deploy preview URL: when I press the "Getting Started" button on a large screen, all of the header options disappear.

amitamrutiya avatar Aug 30 '24 07:08 amitamrutiya

@hymmns, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

ashparshp avatar Aug 31 '24 07:08 ashparshp

@amitamrutiya, I have made the changes as requested.

hymmns avatar Aug 31 '24 23:08 hymmns

@hymmns, Join slack please.

ashparshp avatar Sep 01 '24 18:09 ashparshp

Thanks for the invite @Ashparshp

hymmns avatar Sep 01 '24 23:09 hymmns

@hymmns,

Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

ashparshp avatar Sep 09 '24 06:09 ashparshp

@hymmns, I have added this as an agenda item to the meeting minutes. Please join the evening call.

ashparshp avatar Sep 09 '24 06:09 ashparshp

@hymmns what did we conclude with respect to this PR?

leecalcote avatar Oct 17 '24 13:10 leecalcote

Thanks @leecalcote, Will do

hymmns avatar Oct 18 '24 04:10 hymmns

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 19 '24 08:11 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Nov 27 '24 22:11 stale[bot]