meshery.io
meshery.io copied to clipboard
[UI] Fix Navbar not closing on click getting started in mobile view
Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | a661d4260457bbeb2f8233b65d0bdab96f36a5ff |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/6714049865baf60008ddc158 |
| Deploy Preview | https://deploy-preview-1889--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
It would also be good to keep the animation we already have when closing the navbar menu.
Ok thanks @amitamrutiya Will get on it as soon as I can
@amitamrutiya and @sudhanshutech does this address your comments
Whoa @hymmns, you did an excellent job! One more request: if you can figure out how to do this, could you please add a smooth scrolling effect when we press the "Getting Started" button, regardless of the screen size?
I found an issue in your deploy preview URL: when I press the "Getting Started" button on a large screen, all of the header options disappear.
@hymmns, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.
@amitamrutiya, I have made the changes as requested.
@hymmns, Join slack please.
Thanks for the invite @Ashparshp
@hymmns,
Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.
@hymmns, I have added this as an agenda item to the meeting minutes. Please join the evening call.
@hymmns what did we conclude with respect to this PR?
Thanks @leecalcote, Will do
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.