meshery.io
meshery.io copied to clipboard
[mesheryctl] Fall back to stable release
This PR fixes: build-and-release-stable.yml only builds tar if the tags do not contain the suffices: patch, alpha, beta, rc. However, [install] (https://github.com/meshery/meshery.io/blob/master/install) script in meshery.io only strips the patch suffix, leading to being unable to install meshery if there is no tar of the same version, for example
- Latest tag v0.8.0-alpha.1 -> no stripping suffix, latest version will be v0.8.0-alpha.1 but no tar ball to install
- Latest tags v0.8.0-patch.2 v0.8.0-patch.1 -> stripping suffix, but no v0.8.0 with tar ball This PR uses git ls-remote to query the latest tags of meshery and exclude all the tags with suffices alpha, beta, patch, and rc
Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | 1177ab67d6fe6020f6be860ad7d8dc2b4fc54b04 |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/66cb0c163fa8d500081395e0 |
| Deploy Preview | https://deploy-preview-1886--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@da0p, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.
@Ashparshp Thanks! Is there another way we can discuss it? I am usually not available at the time of the websites meeting
@vishalvivekm //
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.