meshery.io
meshery.io copied to clipboard
[UI]: Meshery extension catalog modal image height fix
Description
This PR fixes #1881
Notes for Reviewers
I've resolved this by adding a height:100% to the image tag CSS
- [x] Yes, I signed my commits.
Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | f50f1b7acc36bb981b0542b0e8aae346d2933021 |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/671e8ce5b1f4ac0008298f0a |
| Deploy Preview | https://deploy-preview-1882--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@SAHU-01, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.
@SAHU-01 few snapshots images is streched out . Is this due to this change? I think yes!
Yes, I'll check these and fix it! Thank you for highlighting the same.
Sure I'll get rid of the linting changes.
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:
@SAHU-01, just a reminder in case you missed this.
@SAHU-01 ?
@vishalvivekm thank you for highlighting this, I'll remove the unecessary linting changes .
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.
