meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

Pop-up does not show video controls on large screens

Open Muhammed-Moinuddin opened this issue 1 year ago β€’ 9 comments

Description

On page https://meshery.io/catalog , after clicking import any catalog item link there is a pop-up containing video tutorial. So on large screen the video controls are not visible.

Expected Behavior

The pop-up needs to be responsive on large screens, so it shows video controls.

Screenshots

On large screens ss1

On normal screens ss2

I would like to work on it.

Enviroment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

Muhammed-Moinuddin avatar Jun 25 '24 12:06 Muhammed-Moinuddin

Users are unable to scroll down the page to see the controls, is that right, @Muhammed-Moinuddin?

leecalcote avatar Jul 03 '24 20:07 leecalcote

I can try solving this issue @leecalcote @Muhammed-Moinuddin

kanishk6103 avatar Jul 03 '24 20:07 kanishk6103

Users are unable to scroll down the page to see the controls, is that right, @Muhammed-Moinuddin?

You would have been right if pop-up were a part of the screen. But it's not like that, screen is separate from pop-up and is scrollable so we just need to make pop-up a bit responsive for the large screens.

Muhammed-Moinuddin avatar Jul 04 '24 00:07 Muhammed-Moinuddin

Perfect.webm

Thank you for your work on this issue. However, after reviewing your fix, I found that the original functionality was perfectly fine, and the video controls were visible as intended. Therefore, I don't believe this is a valid issue. Could you please double-check from your side?

ashparshp avatar Jul 04 '24 20:07 ashparshp

@Muhammed-Moinuddin Also, in the future, could you please wait for assignment or confirmation before starting work on an issue?

ashparshp avatar Jul 04 '24 20:07 ashparshp

Perfect.webm Thank you for your work on this issue. However, after reviewing your fix, I found that the original functionality was perfectly fine, and the video controls were visible as intended. Therefore, I don't believe this is a valid issue. Could you please double-check from your side?

It is valid issue, the browser makes it like scrollable but it is not and video controls are hiding due to it. We'll discuss this in upcoming meeting.

Muhammed-Moinuddin avatar Jul 04 '24 21:07 Muhammed-Moinuddin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 09 '24 05:08 stale[bot]

I can try solving this issue @leecalcote @Muhammed-Moinuddin Can you please assign me to this issue?

subh05sus avatar Apr 05 '25 07:04 subh05sus

Thank you @subh05sus. Assigned

vishalvivekm avatar May 11 '25 18:05 vishalvivekm

@vr-varad @vishalvivekm may I work on this issue? I’m new to the community.

mohammedfirdouss avatar Aug 12 '25 05:08 mohammedfirdouss