meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

Adjusted div length to ensure equal height in modal

Open ayush844 opened this issue 1 year ago • 3 comments

Description

This PR fixes #1637

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

ayush844 avatar Apr 06 '24 11:04 ayush844

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit 407ef5d7583b4abb67bf9d0a663672500d960554
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/661138945cbcd5000820e9cf
Deploy Preview https://deploy-preview-1702--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 06 '24 11:04 netlify[bot]

here the modal is working fine when we zoom out by any amount and zoom in till (125 - 130%)

Screenshot from 2024-04-06 17-47-35

also both the paragraph are truncated after 3 lines, so extra content should not cause any issue

ayush844 avatar Apr 06 '24 12:04 ayush844

@ayush844 Let's discuss this on websites call. Add this as an agenda item to the meeting minutes, if you would :)

vishalvivekm avatar Apr 07 '24 17:04 vishalvivekm

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 15 '24 02:05 stale[bot]

Hi @ayush844 since this is already fixed, I am closing this PR!

iArchitSharma avatar May 17 '24 10:05 iArchitSharma