meshery.io
meshery.io copied to clipboard
meshery
Optimized modal layout to ensure consistent background color coverage
Description
This PR fixes #1637
Notes for Reviewers
- [x] Yes, I signed my commits.
Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | c51cae7f9adfa0b9d9e8a2d80b4f3a5e0a1c60b5 |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/65e745456b7bb50008b737e3 |
| Deploy Preview | https://deploy-preview-1641--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @ayush844 , Thanks for your PR! I encourage you to share this in the Website Meeting on Monday at 6:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.
You're welcome at the meeting
Check to community calendar for more details of meetings at Layers.
@jameshorton2337, i don't think there will be any negative side affects with it, as the vertcal line which seperates left section and right section is also set to more than 100% (114%)
@jameshorton2337, i don't think there will be any negative side affects with it, as the vertcal line which seperates left section and right section is also set to more than 100% (114%)
Thanks. Why don't we bring both sides to 100%?
if we set both to 100%, this is what we are getting:
we can change height of vertical line to 100%, but then we need to change height of .modal-image (left section) to 89.5% to match with the other parts, this is how it will look:
but in this case we'll not be able to scroll inside the modal, which will may cause issue when we have bigger content to show inside the modal
@sudhanshutech I've been busy with my university exams lately, so I haven't had time to make the changes you suggested for the PR. My exams finish in two days, and then I'll get right back to it.
@sudhanshutech yes, just started working on it. will share the updates soon