meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

[Catalog] Inconsistent Background Color in Pop-up: Left Side Does Not Extend to Full Height

Open ayush844 opened this issue 1 year ago • 7 comments

Name: For All Patterns Type: - Compatibility: - Pattern ID: - image: WhatsApp Image 2024-02-12 at 16 21 09

Description: The pop-up on the catalog section, showing info about different patterns, have some inconsistency in design. The left side, with a dark background doesn't reach all the way down. It changes to a lighter color at the bottom, which looks weird.

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

ayush844 avatar Feb 12 '24 11:02 ayush844

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.

welcome[bot] avatar Feb 12 '24 11:02 welcome[bot]

i am ready to work on this issue, you can assign it to me

ayush844 avatar Feb 12 '24 15:02 ayush844

it'll work fine, if we change height of .modal-image to 103.25%

Screenshot from 2024-02-14 08-21-21

ayush844 avatar Feb 14 '24 02:02 ayush844

hey @ritiksaxena124, please review this PR

ayush844 avatar Feb 17 '24 04:02 ayush844

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 25 '24 12:04 stale[bot]

@abhishekmmgn will you evaluate as to whether this is still outstanding?

leecalcote avatar Apr 25 '24 19:04 leecalcote

Because this PR has not been merged

abhishekmmgn avatar Apr 27 '24 16:04 abhishekmmgn

As this issue is already fixed with this - https://github.com/meshery/meshery.io/pull/1705

iArchitSharma avatar May 17 '24 11:05 iArchitSharma