meshery-operator icon indicating copy to clipboard operation
meshery-operator copied to clipboard

[Docs]Support light vs dark mode display of Meshery logo in README

Open KrishAryan opened this issue 2 years ago β€’ 7 comments

Current State

There are some logos in README.md that have very low contrast in either light/dark mode

Desired State

Change the docs such that there is a separate logo for dark/light mode with high contrast


Contributor Guides and Resources

KrishAryan avatar May 29 '22 08:05 KrishAryan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 15 '22 06:07 stale[bot]

Hello there! This'll be my first time contributing to Meshery (and any open source project to be honest :P) and I'd love to take up this issue!

exitflynn avatar Jul 15 '22 13:07 exitflynn

That's great @exitflynn. If you need help feel free to ask away

KrishAryan avatar Jul 15 '22 17:07 KrishAryan

Hey @KrishAryan! The current logos are those which should be displayed in light-mode and to work on this issue, I'll require images that should be displayed in the dark-mode. Out of the four logos, I managed to find the dark-mode version of two from another meshery repository (meshery/meshery). The two which are left with a light-mode only image are the main Meshery logo and the Meshery Operator logo. There is a subtle difference between the two logos used in this repository (meshery/meshery-operator) and meshery/meshery. I can take the light and dark versions of the main logo from there and incorporate them into this repo if that'd be okay.

Or maybe is there any resource that I'm unaware of where I can find the images? (The Figma link given in the issue does not work, it essentially says 'either file not found or you don't have access'. Do let me know if something like this is what I should rather open an issue about.) Also is it time I opened a pull request so that you can see what I changed, how it looks and have a better idea of what I'm talking about?

Also this is my first time actually doing this and so please feel free to provide any constructive criticism without any hesitation, I would be very thankful.

Thanks a lot for your time!

exitflynn avatar Jul 15 '22 21:07 exitflynn

@exitflynn have you attended any newcomers meet? If not then you can watch this https://www.youtube.com/watch?v=RsyydIUT6UI&list=PL3A-A6hPO2INVEknQ4R-VwDMUT9yM_FSm or read this https://docs.google.com/document/d/1tpg2sLxirozNt3Ofr3GdM002f9rExp74EqrsGZBU710/edit

KrishAryan avatar Jul 16 '22 10:07 KrishAryan

Also, try to join the slack channel and ask meshmates about the logo library. They can give you the link.

KrishAryan avatar Jul 16 '22 10:07 KrishAryan

Dark mode version of the Meshery logo and the Meshery Operator logo are not displaying.

leecalcote avatar Aug 17 '22 13:08 leecalcote

@leecalcote hey can I get assigned to this issue?

K0more avatar Sep 25 '22 17:09 K0more

@KrishAryan @leecalcote I have some doubts, would you like to clear them?

K0more avatar Sep 26 '22 18:09 K0more

Sure

KrishAryan avatar Oct 03 '22 11:10 KrishAryan

@KrishAryan I cleared them on slack, ty for the response though!

K0more avatar Oct 04 '22 11:10 K0more