meshery-istio
                                
                                 meshery-istio copied to clipboard
                                
                                    meshery-istio copied to clipboard
                            
                            
                            
                        [CI] Update Multi Platform build and Release workflow
Current Behavior
Currently, the multiplatform.yml file is sending unwanted build arguments to docker build process because of which release tag and commit_sha are not being passed over to the image and hence the version of meshery adapter are not visible on-hovering adapters chips on Meshery UI Dashboard.
Desired Behavior
This would be fixed when correct build args are passed to the docker build step inside multiplatform workfow. Required Args:
- VERSION
- GIT_COMMITSHA
Check this commit for reference: https://github.com/meshery/meshery-consul/commit/446ad170c938c9bfe22e6e8710459d63395b9148
related to: https://github.com/meshery/meshery/issues/6245
Contributor Guides and Resources
- π Meshery Adapters Spreadsheet
- π Meshery Build & Release Strategy
- ππΎππΌ Questions: Layer5 Discussion Forum and Layer5 Community Slack
@theBeginner86, can I work on this issue?
Hi @Goodiec, I believe by mistake you created your PR onto your fork. Will you please see that the PR is created for this repo so that it can be merged? Thanks,
For reference, you can refer to this contributing guide: https://github.com/meshery/meshery/blob/master/CONTRIBUTING.md
@Goodiec Have you been able to submit a new PR to this repo with your changes?
@Goodiec Have you been able to submit a new PR to this repo with your changes?
Done. My apologies, just saw this.