meshery-istio icon indicating copy to clipboard operation
meshery-istio copied to clipboard

[CI] Update Multi Platform build and Release workflow

Open theBeginner86 opened this issue 3 years ago β€’ 2 comments

Current Behavior

Currently, the multiplatform.yml file is sending unwanted build arguments to docker build process because of which release tag and commit_sha are not being passed over to the image and hence the version of meshery adapter are not visible on-hovering adapters chips on Meshery UI Dashboard.

Desired Behavior

This would be fixed when correct build args are passed to the docker build step inside multiplatform workfow. Required Args:

  • VERSION
  • GIT_COMMITSHA

Check this commit for reference: https://github.com/meshery/meshery-consul/commit/446ad170c938c9bfe22e6e8710459d63395b9148

related to: https://github.com/meshery/meshery/issues/6245


Contributor Guides and Resources

theBeginner86 avatar Oct 05 '22 09:10 theBeginner86

@theBeginner86, can I work on this issue?

Goodiec avatar Oct 05 '22 11:10 Goodiec

Hi @Goodiec, I believe by mistake you created your PR onto your fork. Will you please see that the PR is created for this repo so that it can be merged? Thanks,

For reference, you can refer to this contributing guide: https://github.com/meshery/meshery/blob/master/CONTRIBUTING.md

theBeginner86 avatar Oct 10 '22 17:10 theBeginner86

@Goodiec Have you been able to submit a new PR to this repo with your changes?

acald-creator avatar Nov 09 '22 15:11 acald-creator

@Goodiec Have you been able to submit a new PR to this repo with your changes?

Done. My apologies, just saw this.

Goodiec avatar Nov 09 '22 19:11 Goodiec