meshery-istio icon indicating copy to clipboard operation
meshery-istio copied to clipboard

[Docs] README: Light Mode / Dark Mode support

Open leecalcote opened this issue 3 years ago โ€ข 2 comments

Current Behavior This repo's readme.md (https://github.com/layer5io/layer5#readme) assumes light mode visitors.

Desired Situation Use GitHub's relatively new ability to define light and dark mode images in markdown for each of the logos.

Find light and dark mode flavors of each of the logos here: https://layer5.io/brand or in the shared, community drive.


Contributor Guides and Resources

leecalcote avatar Aug 03 '22 16:08 leecalcote

Hello!

I've just started contributing and was looking for some feedback.

I started with this issue and can't seem to find any resources for the Community/Contributions icon or the Service Mesh Interface Conformance icon.

Do you want me to remake these icons with a gray scale theme?

Thanks!

Here's what I have so far:

image image

jmutton2 avatar Aug 03 '22 18:08 jmutton2

Looking good. Will you kindly use the filled, white version of the Meshery Operator (vs the outline version)? Youโ€™re right: there isnโ€™t a white version of the SMI Conformance icon, yet. Yes, if you would like to attempt to make one, that would be great. Please see the communityโ€™s shared Google Drive for additional assets. Note: we shy away from using grayscale, but instead use reduce or increase opacity levels from a base of #FFFFFF to give a grayscale-like effect, but in (hopefully) more attractive way.

leecalcote avatar Aug 03 '22 19:08 leecalcote

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 07 '22 22:09 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Sep 17 '22 01:09 stale[bot]

@legendarykamal is this something that you can take on?

leecalcote avatar Sep 29 '22 02:09 leecalcote

Sure @leecalcote ๐Ÿ™‚

kamalbuilds avatar Sep 29 '22 05:09 kamalbuilds

@leecalcote if this is about layer5.io then it has already been fixed for dark mode, we had decided to use the green images.

kamalbuilds avatar Sep 29 '22 09:09 kamalbuilds

Sounds good, @legendarykamal.

Likely, I originally opened this issue under the wrong repo or neglected to under the issue description with the Istio adapterโ€™s info. Will you do me a favor and review this repos read me for light and dark mode support? Also, letโ€™s do away with use of the Meshery logo with the tagline and instead use the logo with no tagline.

leecalcote avatar Sep 29 '22 10:09 leecalcote

Ahem! Did someone say light and dark mode? ๐Ÿ˜ƒ๐Ÿ™ƒ

Mr @leecalcote & @legendarykamal , mind if I jump in? ๐Ÿ‘€

NPDebs avatar Oct 06 '22 16:10 NPDebs

oh I think I forgot to file the PR for this. So just saving your efforts @NPDebs , I will do this by today ๐Ÿ˜„ .

kamalbuilds avatar Oct 06 '22 17:10 kamalbuilds

Dang it! ๐Ÿ˜ญ๐Ÿ˜ซ

Sure @legendarykamal . Time to find more repos that attention. ๐Ÿƒ๐Ÿฝโ€โ™€๏ธ

NPDebs avatar Oct 06 '22 17:10 NPDebs

checkout the integrations needed on layer5 they need attention @NPDebs ๐Ÿฆฉ

kamalbuilds avatar Oct 06 '22 17:10 kamalbuilds

Yay! ๐Ÿฅณ๐Ÿฅณ

Do you mean issue #3263 or #3266? ๐Ÿ˜ƒ

NPDebs avatar Oct 06 '22 17:10 NPDebs