shape-builder icon indicating copy to clipboard operation
shape-builder copied to clipboard

Close shape button does not work as expected

Open jagpreetrahi opened this issue 1 month ago β€’ 4 comments

Current Behavior

Functionality of the close shape button does not work as expected, it makes mis-understanding on the page without doing anything.

Expected Behavior

It should work properly as expected , so that it doesn't break the flow.

Screenshots/Logs

Environment

  • Host OS: Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v

Contributor Guides and Handbook

jagpreetrahi avatar Nov 03 '25 13:11 jagpreetrahi

I would like to work on this , @Namanv0509

jagpreetrahi avatar Nov 03 '25 13:11 jagpreetrahi

@jagpreetrahi kindly assign the issue to me i would like to contribute

@Namanv0509 , I explored the behavior of close shape and also go through with svg docs. So what i understand the draw("done") used to stop the drawing mode and finalize the shape right??, So currently , what happening on the page is , when we creating a polygon, we have to click the enter for quitting right? so that we get a shape. But close shape button has the functionality to quit out the drawing mode and finalize the shape. so why we need to click the enter, if we can do this by close button. What do you think on this??

jagpreetrahi avatar Nov 04 '25 07:11 jagpreetrahi

Here is the demo

https://github.com/user-attachments/assets/d95df548-91a1-47d6-a066-2cd5e4a54df8

jagpreetrahi avatar Nov 04 '25 07:11 jagpreetrahi