Stability fixes

[vikulin]

[mwarning]

wow, impressive.

A few questions:

• what features did you add?
• did your bugs did your fix?
• why are the commit messages starting with 1.?
• what linter (how) did you run? I also like to apply that to the develoment branch.

[vikulin]

wow, impressive.

A few questions:

* what features did you add?

Mostly this PR contains simplifications:

• removed encryption since RiV-mesh network supports it by default
• removed MAC in interface list in Settings
• upgraded and refactored WebRTC code

Added features:

• Speaker On mode
• Camera preview while video calling
• Added IPv6 interface support
• Added Acra for crash reports
• Debug info with Vide/Audio codec and stream info: Codec name, bandwidth

* did your bugs did your fix?

• fixed unexpected interruption while calling

* why are the commit messages starting with `1.`?

• It's used for commit index

* what linter (how) did you run? I also like to apply that to the develoment branch.

• Used AndroidStudio and tested on Android 5.0, Android 10 also showed good results

Generally this is preparation for re-brending and much more deep changes in GUI. If you prefer to keep the same name (meshenger) let discuss it in telegram channel.

[mwarning]

I see, but this cannot be merged here when removing encryption and mac support. It might be a good idea to make all this optional. But you can do whatever you want. :-)

[vikulin]

You might take several ideas and merge partially/manually. I will keep the project as a fork respecting your afforts as a creator.

чт, 25 нояб. 2021 г. в 22:20, Moritz Warning @.***>:

I see, but this cannot be merged here when removing encryption and mac support. It might be a good idea to make all this optional. But you can do whatever you want. :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/meshenger-app/meshenger-android/pull/55#issuecomment-979453728, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVRRXI37U2QCQOYCQ5NJDUN2LBBANCNFSM5IY33LIQ .

[mwarning]

I do not mind if you want to remove the fork relationship. I will see what bugfixes and features I can merge and say thank you.

[vikulin]

Yes, interface address may contains % symbol

чт, 25 нояб. 2021 г. в 23:36, Moritz Warning @.***>:

@.**** commented on this pull request.

In app/src/main/java/d/d/meshenger/Utils.java https://github.com/meshenger-app/meshenger-android/pull/55#discussion_r757133763 :

@@ -289,8 +294,14 @@ public static boolean isIP(String address) { addressList.add(new AddressEntry(addr.getHostAddress(), nif.getName(), addr.isMulticastAddress())); if(fullAddress.indexOf('%')>0){ String subaddress = fullAddress.substring(0, fullAddress.indexOf('%'));

•                    if(isIPv6(subaddress)){
  

•                        subaddress="["+subaddress+"]";
  

Is this a problem somewhere?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/meshenger-app/meshenger-android/pull/55#pullrequestreview-816304290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVRRUGJ25RL4D5G7HBKPDUN2T37ANCNFSM5IY33LIQ .

[vikulin]

I see, but this cannot be merged here when removing encryption and mac support. It might be a good idea to make all this optional. But you can do whatever you want. :-)

WebRTC from Google should support encryption. Isn't it?

[mwarning]

WebRTC itself is encrypted, but the initial key parameter exchange of a WebRTC call is not. And there is no authentication there. So for this initial packet exchange crypto/authentication is added by Meshenger.

EDIT: had to fix the wording

[vikulin]

Are you referring to a MITM attack?

пт, 26 нояб. 2021 г. в 09:55, Moritz Warning @.***>:

WebRTC itself is encrypted, but the initial key exchange is not.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/meshenger-app/meshenger-android/pull/55#issuecomment-979762447, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVRRWCPAPGVQ2NRWG2DIDUN44PNANCNFSM5IY33LIQ .

[mwarning]

Yes, for example MIM.

[opusforlife2]

@mwarning Will you be releasing a new version with code picked from here, then?

[mwarning]

@opusforlife2 I will try to integrate some things into the development branch which hopefully turn into a new release. But the problem is available time..

[vikulin]

@opusforlife2 I will try to integrate some things into the development branch which hopefully turn into a new release. But the problem is available time..

Consider kotlin migration for all code which I have already done:

https://github.com/meshenger-app/meshenger-android/pull/55/files

[mwarning]

@opusforlife2 I will try to integrate some things into the development branch which hopefully turn into a new release. But the problem is available time..

Consider kotlin migration for all code which I have already done:

https://github.com/meshenger-app/meshenger-android/pull/55/files

I always wanted to migrate to Kotlin. :-)

[vikulin]

Done release v0.4.0.7:

1.Tested Kotlin version 2.Redesigned Choose Address form 3.Bufixes

[mwarning]

Hi @vikulin, I started to integrate some of your fixes into the repository. Let's close this MR for now, since it won't be merged directly.

[vikulin]