engine icon indicating copy to clipboard operation
engine copied to clipboard

Do not use transaction data to read result

Open antho1404 opened this issue 4 years ago • 0 comments

We should not use the data of a transaction to read the hash of a resource as the behavior might be totally different from transaction that contains multiple messages. It is still manageable if all the messages are the same but if we send different messages that will be a mess.

I suggest reading this information directly from the logs of the result (the events emitted) and not the data and remove all information that we put in the transaction data in order to force us to use the events more.

Example of code reading from the data and that should have some issues with multiple messages https://github.com/mesg-foundation/engine/blob/dev/cosmos/module_client.go#L174

antho1404 avatar Apr 03 '20 07:04 antho1404