engine icon indicating copy to clipboard operation
engine copied to clipboard

Remove service's SID

Open antho1404 opened this issue 5 years ago • 2 comments

https://github.com/mesg-foundation/engine/blob/16d8a328d291998faada8de05ad0b47d86630bbd/sdk/service/backend.go#L131-L134

This modification should be done before the hash is calculated.

Now, we cannot recalculate the hash based on the data in the database

antho1404 avatar Sep 30 '19 08:09 antho1404

The sid should be removed as discussed previously. It should be removed before putting it on test net.

So, in fact, this issues should be about removal sid at all.

krhubert avatar Sep 30 '19 08:09 krhubert

Sid should be simply removed. They are currently only used to use the same volume if the service is updated: https://github.com/mesg-foundation/engine/blob/ccf5ecc7ff60a7a02df7170b6e5c7ed07b414def/runner/builder/container.go#L267-L275

related to https://github.com/orgs/mesg-foundation/projects/25#card-34695740

NicolasMahe avatar Mar 17 '20 08:03 NicolasMahe