Mert

Results 543 comments of Mert

Wouldn't it be better to set the orientation tag in the preview and thumbnail instead of regenerating them?

Are you sure it can do hardware decoding without a Mali driver? Edit: Ah, I see it's only used for tone-mapping. I think we can relax this to let it...

> @mertalev were you able actually to test pgvector upgrades? I tested pgvecto.rs 0.2.0 -> 0.3.0 and immich 1.90.2 (last typesense release) -> this PR

> The mobile app can't actually send null How can it not send null? That's so weird. In that case I'd rather handle the '' => null conversion as a...

The empty string / null handling is the main outstanding issue. It'd be great if you could add a '' => null transformer in the request DTO and remove the...

It's supposed to only re-transcode etc. if the file modification date for the asset has changed. Can you confirm if this is the case for you?

When it needs to tone-map and OpenCL isn't available, the command won't work. This is because the HW config's input options will keep the frames in the GPU, but the...

Sorry, I haven't tested it yet. I might have time to take a look at it tomorrow.

I had to change `format=yuv420p10le` to `format=p010` for the tone-mapping command without OpenCL to work, but it otherwise works pretty well. I also added `async_depth=4` to all the scaling commands...

There is an "Exif Image Width/Height" field in the CR2 sample above that's accurate. Can you check with exiftool if the RAF file also has this? We could prefer this...