Mert

Results 543 comments of Mert

> Thank you for the high quality PR. > > Can you explain briefly how you achieve the infinite scrolling, especially on the performance aspect? Will it cause a performance...

I can confirm it starts degrading for me at 7k+ assets. The scrolling starts getting jittery, the next page takes longer to load and the thumbnails don't show up as...

I think we can set a 50 page limit to prevent the number of assets from getting out of hand.

I'm not sure how I feel about this. It adds a lot of complexity to facial recognition, which is already complex enough as it is. Is the idea for this...

I really appreciate the effort you put into this! It definitely comes across in the code. That being said, there are a few issues and I'm not sure if they...

> I wonder if there is a way to use the exif facial data in just the clustering portion of the existing implementation. Basically set the initial clusters from that...

> As an alternative, would it be possible to make embedding nullable so that faces from metadata have embedding==null and these can be skipped in searchCLIP and searchFaces by adding...

I think that approach would work well. Two notes: 1. This would mean updating the ML service to support running the recognition model on an already cropped image instead of...

I think this change can actually double as a way to easily test facial recognition. Most facial recognition datasets are meant to be fed directly to a recognition model without...

I don't think we need a new field. We could just add a face to the image metadata that spans the entire image.