dynarmic icon indicating copy to clipboard operation
dynarmic copied to clipboard

Automated testing failing at msr and vcvt.f32.f16

Open Wunkolo opened this issue 4 years ago • 3 comments

Across different branches(and PRs), I'm getting fuzz-test failures in particular around the msr instruction and vcvt.f32.f16 qn, dm. Also seems to have happened on master a few times.

msr failures https://github.com/MerryMage/dynarmic/pull/619/checks?check_run_id=2721379195#step:10:144 https://github.com/MerryMage/dynarmic/pull/619/checks?check_run_id=2721379100#step:10:146 https://github.com/MerryMage/dynarmic/pull/616/checks?check_run_id=2712829271#step:10:148 https://github.com/MerryMage/dynarmic/pull/619/checks?check_run_id=2750055067#step:10:148 https://github.com/Wunkolo/dynarmic/runs/2721267611?check_suite_focus=true#step:10:146

mainline instances https://github.com/MerryMage/dynarmic/runs/2710439806#step:10:817

vcvt fixed in https://github.com/MerryMage/dynarmic/commit/828959caedfac2d456a0c877fda4612e35fffc03 ~~vcvt.f32.f16 failures~~ ~~https://github.com/MerryMage/dynarmic/pull/619/checks?check_run_id=2721379161#step:10:173~~ ~~https://github.com/MerryMage/dynarmic/pull/616/checks?check_run_id=2712829139#step:10:171~~ ~~https://github.com/MerryMage/dynarmic/pull/619/checks?check_run_id=2750055095#step:10:172~~ ~~https://github.com/MerryMage/dynarmic/pull/619/checks?check_run_id=2750055106#step:10:175~~ ~~https://github.com/Wunkolo/dynarmic/runs/2721292621?check_suite_focus=true#step:10:173~~ ~~https://github.com/Wunkolo/dynarmic/runs/2721267582?check_suite_focus=true#step:10:173~~

~~mainline instances~~ ~~https://github.com/MerryMage/dynarmic/runs/2710422780#step:10:172~~

Wunkolo avatar Jun 01 '21 18:06 Wunkolo

The vcvt.f32.f16 issue seems to be an issue when processing float16 NaN values like 0xff88 turning into 0xfff10000 while unicorn is expecting 0x7fc00000(default nan) despite the DN flag not being set though. Unicorn might be the one default-nan-ing things when it shouldn't.

Wunkolo avatar Jun 04 '21 05:06 Wunkolo

msr looks like a weird unicorn bug where it thinks the instruction is 2 bytes instead of 4.

merryhime avatar Jun 04 '21 09:06 merryhime

vcvt fixed in 828959caedfac2d456a0c877fda4612e35fffc03

merryhime avatar Jun 05 '21 17:06 merryhime