mermaid icon indicating copy to clipboard operation
mermaid copied to clipboard

feat: Add Venn diagram

Open exoego opened this issue 1 year ago • 5 comments

:bookmark_tabs: Summary

Resolves #2583

:straight_ruler: Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

:clipboard: Tasks

Make sure you

  • [ ] :book: have read the contribution guidelines
  • [ ] :computer: have added necessary unit/e2e tests.
  • [ ] :notebook: have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • [ ] :butterfly: If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Screenshot

image

exoego avatar Oct 04 '24 15:10 exoego

🦋 Changeset detected

Latest commit: 7111a853d90821ab87963994cd9dd8c3ed7cf068

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 04 '24 15:10 changeset-bot[bot]

Deploy Preview for mermaid-js ready!

Name Link
Latest commit 7aefbc3e3238a5ee5e39699fb2d5a429c628216d
Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/671d82ff0f23800008178ea3
Deploy Preview https://deploy-preview-5932--mermaid-js.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 04 '24 15:10 netlify[bot]

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@5932
mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@5932
@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5932
@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@5932
@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5932
@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5932
@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@5932

commit: 7111a85

pkg-pr-new[bot] avatar Oct 05 '24 07:10 pkg-pr-new[bot]

Codecov Report

:x: Patch coverage is 2.12202% with 369 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 3.56%. Comparing base (d5bc07d) to head (7111a85).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/venn/vennRenderer.ts 0.51% 195 Missing :warning:
packages/mermaid/src/diagrams/venn/vennDB.ts 0.99% 100 Missing :warning:
packages/mermaid/src/diagrams/venn/styles.ts 0.00% 36 Missing :warning:
packages/mermaid/src/diagrams/venn/vennDetector.ts 7.14% 13 Missing :warning:
packages/examples/src/examples/venn.ts 10.00% 9 Missing :warning:
packages/mermaid/src/diagrams/venn/vennDiagram.ts 10.00% 9 Missing :warning:
...s/mermaid/src/diagram-api/diagram-orchestration.ts 0.00% 3 Missing :warning:
packages/examples/src/index.ts 0.00% 2 Missing :warning:
.build/jsonSchema.ts 0.00% 1 Missing :warning:
packages/mermaid/src/docs/.vitepress/config.ts 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5932      +/-   ##
==========================================
- Coverage     3.57%   3.56%   -0.02%     
==========================================
  Files          473     480       +7     
  Lines        47475   47851     +376     
  Branches       734     741       +7     
==========================================
+ Hits          1696    1704       +8     
- Misses       45779   46147     +368     
Flag Coverage Δ
unit 3.56% <2.12%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/config.type.ts 100.00% <ø> (ø)
packages/mermaid/src/defaultConfig.ts 41.31% <100.00%> (+0.55%) :arrow_up:
packages/mermaid/src/diagrams/venn/vennTypes.ts 100.00% <100.00%> (ø)
.build/jsonSchema.ts 0.00% <0.00%> (ø)
packages/mermaid/src/docs/.vitepress/config.ts 0.40% <0.00%> (-0.01%) :arrow_down:
packages/examples/src/index.ts 2.08% <0.00%> (-0.10%) :arrow_down:
...s/mermaid/src/diagram-api/diagram-orchestration.ts 0.00% <0.00%> (ø)
packages/examples/src/examples/venn.ts 10.00% <10.00%> (ø)
packages/mermaid/src/diagrams/venn/vennDiagram.ts 10.00% <10.00%> (ø)
packages/mermaid/src/diagrams/venn/vennDetector.ts 7.14% <7.14%> (ø)
... and 3 more
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 05 '24 07:10 codecov[bot]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jan 3, 2026, 8:05 AM

argos-ci[bot] avatar Oct 05 '24 07:10 argos-ci[bot]

This draft has broken CI and conflicts, how can we move It forward?

piranna avatar Dec 17 '24 14:12 piranna

I am still working to add text nodes in each circle.

exoego avatar Dec 17 '24 21:12 exoego

+1 any timeline on this one? :)

FKSI avatar Apr 08 '25 10:04 FKSI

wen

dgrr avatar Jul 15 '25 17:07 dgrr

This draft has broken CI and conflicts, how can we move It forward?

By forking @exoego 's PR and fixing the conflicts + broken CI. Hopefully adding the text in each node as he mentioned.

schoettler avatar Sep 16 '25 20:09 schoettler

It's a shame that this stalls, looks like a solid implementation of a very needed feature

Inviz avatar Oct 23 '25 01:10 Inviz

Deploy Preview for mermaid-js ready!

Name Link
Latest commit 7111a853d90821ab87963994cd9dd8c3ed7cf068
Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6958cb9ca192b1000823632a
Deploy Preview https://deploy-preview-5932--mermaid-js.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Dec 21 '25 10:12 netlify[bot]