mermaid icon indicating copy to clipboard operation
mermaid copied to clipboard

Use issue templates and add diagram, theme and syntax proposal issue forms

Open Andre601 opened this issue 3 years ago • 6 comments

:bookmark_tabs: Summary

This PR does a few things:

  • Moves issue templates to GitHub's new Issue forms.
  • Add a config.yml to the issue templates
    • This adds links to Discussions (if enabled, as suggested here), Slack, the Documentation and Live Editor
    • Disables the option to create blank issues (Possible spam-protection for the future.)
  • Splits the feature request template into three distinct templates, as suggested in #2456
  • Removes the Question template in favour of recommending Discussions.

Related issue: #2456

A bit more context: The PR remains a draft for now until clear responses have been given as to if discussions should be enabled or not.

I'm in favour of using Discussions over issues for Questions as they offer a way to mark a response as answer, which in the end can create a healthy knowledge base. Coupled with the fact that you can also migrate issues to Discussions, have categories that don't have a "Mark as Answer" option, which can be useful for stuff like sharing Setups or Diagram designs, and have an option for a news category that allows collaborators to post stuff such as announcements without the fear of other people spamming the category, I feel like Discussion would be a superior choice here.

If for whatever reason you decide against this would I simply re-create the question form and mark the PR as ready. Otherwise, would I uncomment the entry with the discussion link in the config.yml and mark the PR as ready.

I hope my points are clear and understandable. 😅

:straight_ruler: Design Decisions

The idea is to use GitHub's issue forms for a more streamlined and consistent syntax for issues, which can help with support and feature requests.

:clipboard: Tasks

Make sure you

  • [x] :book: have read the contribution guidelines
  • [x] :computer: have added unit/e2e tests (if appropriate)
  • [x] :bookmark: targeted develop branch

Andre601 avatar Feb 16 '22 21:02 Andre601

Hey, this will be quite helpful with proper templates. Thanks for picking this one up.

For your question regarding keeping the discussion open, we as such are on board with the idea for people to discuss. However, we are really a very small team working actively on Mermaid. It will be hard for us to answer questions in a timely fashion.

We can surely keep the discussion open, maybe as we get more contributors and the team grows, we will be able to handle it.

ashishjain0512 avatar Feb 17 '22 16:02 ashishjain0512

For your question regarding keeping the discussion open, we as such are on board with the idea for people to discuss. However, we are really a very small team working actively on Mermaid. It will be hard for us to answer questions in a timely fashion.

We can surely keep the discussion open, maybe as we get more contributors and the team grows, we will be able to handle it.

I feel like you misunderstood my comment?

The only thing I did was suggesting to enable and use GitHub Discussions as a replacement for the questions template (And maybe also for stuff such as announcements and sharing setups and stuff).

So not sure what exactly you mean with your comment.

Andre601 avatar Feb 17 '22 21:02 Andre601

@Andre601 Yes, that sounds like a good idea. Sorry, I misunderstood your previous comment. Let's enable GitHub Discussions.

ashishjain0512 avatar Feb 24 '22 17:02 ashishjain0512

@knsv Could you enable GitHub Discussions?

Yash-Singh1 avatar Apr 28 '22 22:04 Yash-Singh1

@Andre601 Discussions are enabled now. The new templates are fantastic, we can get them in if you can get the PR ready!

sidharthv96 avatar Sep 08 '22 04:09 sidharthv96

Not sure if I can resolve the current file conflicts, as GitHub doesn't provide me with any option to resolve it (Not even instructions on how it's done on the command line, which it usually shows for too complicated conflicts)

image

Edit: It seems like I actually cant. git status returns 0 conflicts in the command line, so there is - at least for git - no conflict present it would need to deal with... I guess this is something you guys need to fix on your end.

Andre601 avatar Sep 14 '22 23:09 Andre601

Edit: It seems like I actually cant. git status returns 0 conflicts in the command line, so there is - at least for git - no conflict present it would need to deal with... I guess this is something you guys need to fix on your end.

I used VS Code and merged the latest develop into your branch.

sidharthv96 avatar Oct 29 '22 18:10 sidharthv96

I used VS Code and merged the latest develop into your branch.

Thank you. Still not sure why it didn't work on my end.

Andre601 avatar Oct 29 '22 19:10 Andre601

.github/ISSUE_TEMPLATE/syntaxt_proposal.yml → .github/ISSUE_TEMPLATE/syntax_proposal.yml

Spam bot

Andre601 avatar Nov 03 '22 10:11 Andre601