mermaid-cli icon indicating copy to clipboard operation
mermaid-cli copied to clipboard

Published 20 hours ago • verified publisher icon mermaid-js

bug: add style node to SVG

Open joelburton opened this issue 4 years ago • 2 comments

Rudimentary solution for "custom CSS not in SVG" #55

joelburton avatar Oct 08 '20 07:10 joelburton

Thank you for your PR!

Before I can accept your PR, I need at least one automated test. Please, get the latest changes from master and implement an e2e test in the run-tests.sh. Get inspired from the existing tests. I propose this testing strategy:

  1. Create a css file for one of the existing diagrams in test-positive/. css file should have the same name as the diagram file and be placed in the same folder.
  2. Create an svg from the diagram with css using mmdc.
  3. Convert svg to png using one of Linux utilities (Percy test framework does not work with svg files)

That is it! 😄 I will be on vacation next week with a limited access to the internet. But I will get back to your PR a week after.

Have a really great day!

MindaugasLaganeckas avatar Oct 10 '20 05:10 MindaugasLaganeckas

Closes #55

MindaugasLaganeckas avatar Oct 10 '20 05:10 MindaugasLaganeckas