ngx-material-file-input icon indicating copy to clipboard operation
ngx-material-file-input copied to clipboard

Angular 15/Material 15 support

Open mattytommo opened this issue 1 year ago • 14 comments

Could we possibly get Angular 15 & Material 15 support? This is the only package I have that doesn't support 15, so would be good to get it upgraded :).

mattytommo avatar Nov 23 '22 14:11 mattytommo

We're also using den --legacy-peer-deps in our project because ngx-material-file-input is still lacking support for Angular 15. We can't wait for the upgrade.

rakia avatar Jan 04 '23 12:01 rakia

Yes please, this would be highly appreciated

Paci3491 avatar Mar 05 '23 21:03 Paci3491

hey! would be great to upgrade!

APOSWE avatar Mar 09 '23 06:03 APOSWE

any information when it will be updated? i can try to create PR if it needed, but i saw another PR that was rejected as i can see

mamay12 avatar Mar 20 '23 23:03 mamay12

Hope the PR with legacy material implementation could be accepted soon. Really looking forward on angular 15 support ! Thanks for the great work on this project.

Elvynia avatar Apr 10 '23 12:04 Elvynia

Can someone explain why this is a difficult change to make, so we can understand why these major version releases of angular / material take so long to be applied?

dnordahl1 avatar May 01 '23 23:05 dnordahl1

@dnordahl1 Read angular migration guides to know what changes with new versions: Update Angular to v15 on Material components

Many of the components in Angular Material v15 have been refactored to be based on Angular Material Design Components (MDC) for the Web. The refactored components offer improved accessibility and adherence to the Material Design spec.

For more information about the updated components, see Migrating to MDC-based Angular Material Components

Elvynia avatar May 02 '23 13:05 Elvynia

@Elvynia After getting through the Angular 15 package update challenges, I now see how the MDC-based redesign and deprecation of nearly all existing material components creates major challenges to say the least.

dnordahl1 avatar May 02 '23 18:05 dnordahl1

Angular 15 has been released mid november last year, what more, the current version of Angular is 16 (just got released), but the package still does not support v15. When will this issue will be solved?

D4nyi avatar May 04 '23 06:05 D4nyi

Is this package no longer maintained?

yakeer avatar May 11 '23 06:05 yakeer

Hey guys! I forked this repo and implemented a quick fix here

Apologies to the main contributors to this project, but I needed to fix it as I used this library in my own project.

Please let me know if my fix is sufficient to create a pull request here so that I'd remove my fork.

Thanks!

P.S.: Thanks, benceHornyak! You had practically solved it, I just gave it the final push :)

franbueno avatar Jun 15 '23 23:06 franbueno

In our project, I get rid of the --legacy-peer-deps flag after replacing this library with an own implemented file-upload component.

It's an Angular custom form-field that does the same as this library & it works with Angular 15 and Angular 16.

You can find it in my repo here. Feel free to use it in your project :)

rakia avatar Jun 16 '23 21:06 rakia

Hey guys! I forked this repo and implemented a quick fix here

Apologies to the main contributors to this project, but I needed to fix it as I used this library in my own project.

Please let me know if my fix is sufficient to create a pull request here so that I'd remove my fork.

Thanks!

P.S.: Thanks, benceHornyak! You had practically solved it, I just gave it the final push :)

Cool. Do you think about publishing this fork on npm registry?

leogouveia avatar Aug 28 '23 17:08 leogouveia

I just published the package in the Angular 15 version:

  • Npm, (npm i ngx-custom-material-file-input)
  • Repo

Remember to change the references in the project to use the new ones: ngx-custom-material-file-input, here in the demo project you have an example.

I have tested it only in the library's demo project, for now just note that the placeholder no longer works and a mat-label must be used.

If you find any problem, tell me or raise an issue in the new repo and we will review it together :D (Just to clarify, I am not an expert in the library but given the need I created this new package to use.)

daemons88 avatar Dec 20 '23 13:12 daemons88