iOS-Open-GPX-Tracker icon indicating copy to clipboard operation
iOS-Open-GPX-Tracker copied to clipboard

New contributor needs help

Open geezerhiker opened this issue 5 years ago • 7 comments

I have made only a trivial change (to give git something to do). I want to contribute but need some help getting started, as described in the attached text file.

Pull Request 1.txt

Hoping to hear from someone soon, Al Heezen

P.S. The file Track.swift should be ignored. It happened to be in the project folder at one point and I don't know how to get it out of the repository.

geezerhiker avatar Aug 07 '20 17:08 geezerhiker

Hi Al Heezen,

I see that there's an empty HTTrack and a Track file that is not associated in the Xcode project, and that you want to remove the Track file right?

As for the signing issues, to build and run on a physical device, you have to change a couple of things. I presume you have logged in with your Apple Developer ID in Xcode. (The free membership works fine.)

  1. you will have to change the bundle identifier. It can be a minor change, like appending your name or even a letter in the bundle identifier (org.merlos.OpenGpxTracker). As long as it is unique, it will work. You have to change for OpenGpxTracker, OpenGpxTracker-Watch, OpenGpxTracker-Watch Extension targets.

  2. After that, you can select your personal team. In my case it shows my name that's associated with my ID.

  3. Next, Go to the OpenGpxTracker-Watch Group > Info.plist. Find the WKCompanionAppBundleIdentifier and change the value to the bundle identifier that you changed to in step 1 (OpenGpxTracker target, not the watch target)

  4. Lastly, go to the OpenGpxTracker-Watch Extension > Info.plist. Find key NSExtension > NSExtensionAttributes > WKAppBundleIdentifier and edit it to match the bundle identifier that you changed to in step 1 (of the OpenGpxTracker-Watch target, not the extension)

As tedious as it is, those are the steps to get signing working for on device tests. Each signing cert can be used for a maximum of 7 days for the free account, meaning after 7 days it won't launch on device, unless you rebuild.

If you encountered any further issues, feel free to let me know.

Vincent

vincentneo avatar Aug 08 '20 03:08 vincentneo

Thanks so much! Can't wait to try it out tomorrow.

I had run into all off the things you mention but I never got the right order and never saw that, if I read you right, those WK…Identifiers are like a linked list reaching back to the main target.

Al

On Aug 7, 2020, at 8:47 PM, Vincent Neo [email protected] wrote:

Hi Al Heezen,

I see that there's an empty HTTrack and a Track file that is not associated in the Xcode project, and that you want to remove the Track file right?

As for the signing issues, to build and run on a physical device, you have to change a couple of things. I presume you have logged in with your Apple Developer ID in Xcode. (The free membership works fine.)

you will have to change the bundle identifier. It can be a minor change, like appending your name or even a letter in the bundle identifier (org.merlos.OpenGpxTracker). As long as it is unique, it will work. You have to change for OpenGpxTracker, OpenGpxTracker-Watch, OpenGpxTracker-Watch Extension targets.

After that, you can select your personal team. In my case it shows my name that's associated with my ID.

Next, Go to the OpenGpxTracker-Watch Group > Info.plist. Find the WKCompanionAppBundleIdentifier and change the value to the bundle identifier that you changed to in step 1 (OpenGpxTracker target, not the watch target)

Lastly, go to the OpenGpxTracker-Watch Extension > Info.plist. Find key NSExtension > NSExtensionAttributes > WKAppBundleIdentifier and edit it to match the bundle identifier that you changed to in step 1 (of the OpenGpxTracker-Watch target, not the extension)

As tedious as it is, those are the steps to get signing working for on device tests. Each signing cert can be used for a maximum of 7 days for the free account, meaning after 7 days it won't launch on device, unless you rebuild.

If you encountered any further issues, feel free to let me know.

Vincent

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/merlos/iOS-Open-GPX-Tracker/pull/180#issuecomment-670818488, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACR42KSLH2IIJFNJXF2LBBTR7TDEXANCNFSM4PX2U5TQ.

geezerhiker avatar Aug 08 '20 05:08 geezerhiker

Oh, and Yes, I do want to remove Track.swift. It's not a big deal - just untidy

Al

On Aug 7, 2020, at 8:47 PM, Vincent Neo [email protected] wrote:

Hi Al Heezen,

I see that there's an empty HTTrack and a Track file that is not associated in the Xcode project, and that you want to remove the Track file right?

As for the signing issues, to build and run on a physical device, you have to change a couple of things. I presume you have logged in with your Apple Developer ID in Xcode. (The free membership works fine.)

you will have to change the bundle identifier. It can be a minor change, like appending your name or even a letter in the bundle identifier (org.merlos.OpenGpxTracker). As long as it is unique, it will work. You have to change for OpenGpxTracker, OpenGpxTracker-Watch, OpenGpxTracker-Watch Extension targets.

After that, you can select your personal team. In my case it shows my name that's associated with my ID.

Next, Go to the OpenGpxTracker-Watch Group > Info.plist. Find the WKCompanionAppBundleIdentifier and change the value to the bundle identifier that you changed to in step 1 (OpenGpxTracker target, not the watch target)

Lastly, go to the OpenGpxTracker-Watch Extension > Info.plist. Find key NSExtension > NSExtensionAttributes > WKAppBundleIdentifier and edit it to match the bundle identifier that you changed to in step 1 (of the OpenGpxTracker-Watch target, not the extension)

As tedious as it is, those are the steps to get signing working for on device tests. Each signing cert can be used for a maximum of 7 days for the free account, meaning after 7 days it won't launch on device, unless you rebuild.

If you encountered any further issues, feel free to let me know.

Vincent

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/merlos/iOS-Open-GPX-Tracker/pull/180#issuecomment-670818488, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACR42KSLH2IIJFNJXF2LBBTR7TDEXANCNFSM4PX2U5TQ.

geezerhiker avatar Aug 08 '20 05:08 geezerhiker

The modification I've pushed to my fork of iOS-Open-GPX-Tracker is not meant to be ready for pushing upstream - more of a “proof of concept” and request for comment.

It is my hope that my stuff could eventually be added as an option that would be selected in the Settings (along with some parameters that could be set by the user).

I’ve tried to change as little as possible. My stuff is enabled or disabled in ViewController by a single Optional named “hikeTracker”; the only real coding change is in locationManager(:didUpdateLocations), where I tried to interfere as little as possible with the existing work (aside from hiding some CLLocations from the map.session and replacing others, which is the whole point of my mod.)

There is some documentation of the process near the head of my HTTrack.swift and HTAggregator.swift - I tried to mark all my stuff with “HT” - and used “//MARK” comments in ViewController.

I haven’t included a great deal of justification but am in the course of generating some nice comparison tracks and look forward to trying to sell the ideas to you all.

P.S. Github continues to puzzle me despite studying up through eh “CONTRIBUTING TO A PROJECT” of Pro Git, much of it more than once. I thought I was trying to make a new Pull Request but the only thing Github will allow me to do is comment on this old one. Must have missed something.

geezerhiker avatar Aug 24 '20 03:08 geezerhiker

Hi Al Heezen,

How should be the app tested in its current state? Would like to know more about the features that this brings. Once I can fully test it, and can fully understand the feature set, I should be able to start cleaning up.

vincentneo avatar Aug 28 '20 14:08 vincentneo

Hello Vincent,

Thanks for replying.

At the moment my mod just spaces out the points that are saved in a track. The whole thing is really a replacement for the one line in the definition of ViewController.locationManager() (beginning at line 103) which sets the spacing like so: manager.distanceFilter = 2 //meters

This may work well in some situations but it does dot work for hiking. Since the horizontal accuracy of the locations is usually a radius of around 5 meters, you would have to get readings about 10 meters apart to be fairly certain that you had actually moved at all! it will save a whole bunch of points in that time and will add in all the 5 meter (or less) errors that result along the way.

On a recent hike I was running the two models simultaneously on the same phone and both came in with a total distance of 6.3 - but GPX Tracker's result was in miles and the new one was in kilometers! A 60% error is actually worse than guessing.

In addition to the spacing, it also does some averaging of the raw readings to make the track smoother. I have a couple other mods that I could add if this looks like something you would consider.

I would make these features standard, if it were up to me, but it is hard to convince some/most people that fewer points can produce a more accurate track, so maybe it is better to make them "optional", in either sense of the word. (They could be turned on with a single Boolean in the Preferences but I stayed away from any changes to the UI, so far.)

And for testing, I've changed the display name in my version so that both can be run on the same device. If you start them both up and go for a walk of 2-3 kilometers (where you can have a pretty good idea of the true distance) you will probably see a significant difference in the track lengths even walking around town or in a park. I could send you some samples, also.

Al

On Aug 28, 2020, at 7:55 AM, Vincent Neo [email protected] wrote:

Hi Al Heezen,

How should be the app tested in its current state? Would like to know more about the features that this brings. Once I can fully test it, and can fully understand the feature set, I should be able to start cleaning up.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/merlos/iOS-Open-GPX-Tracker/pull/180#issuecomment-682660476, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACR42KXTIA4HY6R52RV6BB3SC7ANBANCNFSM4PX2U5TQ.

geezerhiker avatar Aug 29 '20 00:08 geezerhiker

Hi Al Heezen,

GPX Tracker's result was in miles and the new one was in kilometers!

In the preferences you should be able to toggle between imperial or metric units

If you start them both up and go for a walk of 2-3 kilometers (where you can have a pretty good idea of the true distance)

Will try out someday

I could send you some samples, also.

and I won't mind seeing some samples too

vincentneo avatar Sep 03 '20 06:09 vincentneo

Closing PR. Clean up

merlos avatar May 18 '23 20:05 merlos