Prise icon indicating copy to clipboard operation
Prise copied to clipboard

FindPlugin Problem

Open EugeneSu0515 opened this issue 3 years ago • 0 comments

Why don't use PluginTypeName for FindPlugin?

My Situation is there have several implementation plugins within same assembly, so I can't use FindPlugin method to find specific plugin for execute.

I wish that assign PluginTypeName with implementation Type name and FindPlugin method can be implemented find by PluginTypeName as below.

PluginTypeName = implementation.Name, in public virtual Task<IEnumerable<AssemblyScanResult>> Scan(IAssemblyScannerOptions options)

wish be .FirstOrDefault(p => p.PluginTypeName == plugin); or not .FirstOrDefault(p => p.AssemblyPath.Split(Path.DirectorySeparatorChar).Last().Equals(plugin)); in FindPlugin implementation

How about with my recommendation? I wish it can be change in new version. Thanks.

EugeneSu0515 avatar Jun 29 '22 01:06 EugeneSu0515