table icon indicating copy to clipboard operation
table copied to clipboard

[Benchmarks] Support the display of benchmarks through thresholds

Open Startrekzky opened this issue 1 year ago • 2 comments

Goal

Show the benchmark icon on the top-right corner based on the configured thresholds image

Description

This requires users to

  1. define the thresholds for the metrics as below image

    • For the first step, the absolute threshold is enough
    • In addition to the screenshot, allow users to choose the emoji for each threshold

    Please refer to Grafana's doc for more information: https://grafana.com/docs/grafana/latest/panels-visualizations/configure-thresholds/

  2. Display the emoji at the top-right corner of a panel

    • Support it in the Cartesian Chart and Stats chart. For the Cartesian chart, the level depends on which threshold/bucket the avg number of metrics falls into.
    • Provide an option for users to decide whether to show the emoji on the panel.
    • When hovering on the emoji, show the full thresholds (i.e. benchmarks) in readable language.

Startrekzky avatar May 06 '24 04:05 Startrekzky

After discussion, actual requirements are these

Variable

  • add Threshold aggregation

Panel Description

  1. add Show Description checkbox
  2. able to use panel variables in panel description
  3. able to customize panel description's trigger icon
  4. able to use current threshold range's icon as panel description's trigger icon

GerilLeto avatar May 07 '24 02:05 GerilLeto

5.8 Updates: As there are disputes regarding the solutions, the new conclusion is that we'll implement a private component for this feature and see if it works out.

Startrekzky avatar May 08 '24 08:05 Startrekzky