mergestat icon indicating copy to clipboard operation
mergestat copied to clipboard

Add server-side input validation for repo insertions

Open patrickdevivo opened this issue 2 years ago • 1 comments

Related to this work: https://github.com/mergestat/fuse/pull/157 we should add server-side input validation and normalization when adding a new repo, to enforce things like https prefix

patrickdevivo avatar Aug 27 '22 13:08 patrickdevivo

Codecov Report

Merging #162 (a398f73) into main (43799f5) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   68.34%   68.34%           
=======================================
  Files          36       36           
  Lines        1744     1744           
=======================================
  Hits         1192     1192           
  Misses        355      355           
  Partials      197      197           
Impacted Files Coverage Δ
extensions/internal/git/native/blame.go 64.36% <ø> (ø)
extensions/internal/git/native/files.go 63.33% <ø> (ø)
extensions/internal/git/native/stats.go 61.73% <ø> (ø)
extensions/internal/github/org_repos.go 75.34% <ø> (ø)
extensions/internal/github/repo_issues.go 71.22% <ø> (ø)
extensions/internal/github/repo_prs.go 75.14% <ø> (ø)
extensions/internal/github/stargazers.go 71.56% <ø> (ø)
extensions/internal/github/starred_repos.go 68.88% <ø> (ø)
extensions/internal/github/user_repos.go 72.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43799f5...a398f73. Read the comment docs.

codecov-commenter avatar Aug 21 '21 02:08 codecov-commenter

Something to consider here is also repo normalization - for instance https://github.com/mergestat/mergestat vs https://github.com/mergestat/mergestat/.

Both are considered separate repos right now, when they should be recognized as the same

patrickdevivo avatar Sep 26 '22 19:09 patrickdevivo