mergeable icon indicating copy to clipboard operation
mergeable copied to clipboard

Mergeable app cannot be enforced after upgrade to node v20

Open horia-stoenescu opened this issue 1 year ago • 6 comments

Hello,

After doing this upgrade for node version to v20: https://github.com/mergeability/mergeable/pull/738, mergeable app stopped working as it could not read anymore configuration from .github/mergeable.yml.

Also, I cannot see this github app in my status checks for branch protection rules: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks#checks anymore 😞 .

Is there anyone else who saw this kind of issue after the upgrade?

Thank, Horia

horia-stoenescu avatar Mar 12 '24 15:03 horia-stoenescu

I'm having issues after the upgrade as well, I can still see the app in the status checks but it never reports success or failure.

davidalbers avatar Mar 12 '24 15:03 davidalbers

I'm having issues after the upgrade as well, I can still see the app in the status checks but it never reports success or failure.

Yes, same for me. And after removing it from status checks, I could not add it back.

horia-stoenescu avatar Mar 12 '24 15:03 horia-stoenescu

What I've managed to do as a workaround for now:

  • clone mergeable repository
  • get reset --hard HEAD~1 # to return to previous working state
  • start deploy of mergeable self hosted using steps from here: https://github.com/mergeability/mergeable/blob/master/deploy.md

horia-stoenescu avatar Mar 12 '24 17:03 horia-stoenescu

I'll try to revert it back to last known working build

shine2lay avatar Mar 13 '24 00:03 shine2lay

I'll try to revert it back to last known working build

It seems now that it's solved, thanks a lot 😁 . New commits in PRs are able to trigger this check for Mergeable. Also, it can be enabled as required in branch protection rules.

Is there a planned hotfix for this upgrade to node v20? I am asking in order to make sure that no such issues will appear in the near future.

Thank you, Horia

horia-stoenescu avatar Mar 13 '24 10:03 horia-stoenescu

Ho exactly did you upgrade? The referenced PR just bumbed node version in the ci-cd pipeline because some tools required that. That's different from the runtime the bot is hosted with. In Dockerfile its still on 18.

andekande avatar Jun 12 '24 21:06 andekande