mergeable icon indicating copy to clipboard operation
mergeable copied to clipboard

[question] should `skip_merge` also include `Merge pull request...` messages

Open hamza-shezad opened this issue 2 years ago • 3 comments

when skip_merge is true, should commits with messages as following be skipped?

Merge pull request #111 from <repo>`

hamza-shezad avatar Jun 20 '23 08:06 hamza-shezad

Docs https://github.com/mergeability/mergeable/blob/590a40fa9ab9a5f3adbc11273687f043beb91aec/docs/validators/commit.rst#L10

and implementation https://github.com/mergeability/mergeable/blob/590a40fa9ab9a5f3adbc11273687f043beb91aec/lib/validators/commit.js#L69

      orderedCommits = orderedCommits.filter(commit => !commit.message.includes('Merge branch'))

diverge. Merge vs. Merge branch.

=> Fix the implementation?

robinmayerhofer avatar Jul 03 '23 17:07 robinmayerhofer

yes. do you want me to open a PR?

hamza-shezad avatar Jul 04 '23 09:07 hamza-shezad

Yes, I would suggest that you open a PR and ping the maintainers!

robinmayerhofer avatar Jul 05 '23 05:07 robinmayerhofer