mergeable icon indicating copy to clipboard operation
mergeable copied to clipboard

Upgrade Node Version 12 to Latest Node Version 19

Open akhilkumar438 opened this issue 2 years ago • 2 comments

Hi - we're currently actively using the merge bot and the current base image node 12 its not supported anymore and also had some vulnerabilities so we want to upgrade to latest node version 19 before we that we want to make sure latest node version is supported or not.

@jusx @ketan @rtlechow @hemeroc @makuk66

akhilkumar438 avatar Mar 06 '23 17:03 akhilkumar438

I have had success with Node 18 with one caveat. Node 15, I believe, made unhandled Promise rejections an error instead of a warning and these crash the application. To fix this I added:

process.on('unhandledRejection', (reason, promise) => {
  console.log('WARNING: Ignoring unhandled promise rejection at:', promise, 'reason:', reason);
});

to the start of the index.js file.

abid-mujtaba avatar Jan 15 '24 14:01 abid-mujtaba

Version 2.17.6 references node 16; however when I attempt to start the container I get this message: Node.js version 18 is required. You have v16.20.2

When I change the dockerFile reference to Node 18, a test fails:

node[8]: ../src/node_platform.cc:68:std::unique_ptr<long unsigned int> node::WorkerThreadsTaskRunner::DelayedTaskScheduler::Start(): Assertion `(0) == (uv_thread_create(t.get(), start_thread, this))' failed.

However when I updated it to Node 19, it seems to work. But see #739 which says Node 20 will not work.

nightskyguy avatar Apr 06 '24 16:04 nightskyguy