mergeable icon indicating copy to clipboard operation
mergeable copied to clipboard

Release & publish docker images with versioning after release is completed

Open quike opened this issue 3 years ago • 3 comments

We are coming from https://github.com/mergeability/mergeable/issues/554

The purpose of the issue would be to build and publish a new docker mergeable image with the new version after the release is completed. Currently the docker job is ignored and no new builds are published. The idea is to connect both workflows so one follows another one and new artifacts can be deployed to be consumed with the right version.

Besides current Dockerfile is off in comparison of nodejs version used by the app

Dockerfile: FROM node:12.16.0 package.json: 14.15.4

@shine2lay any reason why docker images are not built? github rate limitations?

quike avatar Nov 13 '21 16:11 quike

@quike i am not aware of a blocker to build docker images, we just haven't gotten around to it.

shine2lay avatar Dec 02 '21 16:12 shine2lay

@shine2lay are you planning to enable pushing to https://hub.docker.com/r/mergeability/mergeable? It would be great to have an official build. Based on .github/workflows/docker.yml it looks like adding the secrets DOCKERHUB_PUSH, DOCKERHUB_USERNAME, DOCKERHUB_PASSWORD and DOCKERHUB_REPO would enable this.

boekkooi-lengoo avatar Sep 14 '22 12:09 boekkooi-lengoo

@boekkooi-lengoo looks like it is purposely disabled by them

tenshiAMD avatar Sep 21 '22 15:09 tenshiAMD