Merel Theisen

Results 321 comments of Merel Theisen

Sure go for it @MinuraPunchihewa. I see I never got back to the question: > do you mean use directly the open context manager/write operation? Yes! My point was mainly...

If the changes only need to happen in `kedro-dataset`, breaking it is no big deal. The next release is breaking anyway.

@galenseilisnh , just to clarify is this specifically for the value `"index": False` ?

Use these docs as inspiration for the new tests: https://docs.kedro.org/en/stable/tutorial/test_a_project.html Update these docs to correspond to the test changes: https://docs.kedro.org/en/stable/development/automated_testing.html#create-an-example-test

Some extra context: https://linen-slack.kedro.org/t/22301026/question-is-there-an-extra-step-required-to-run-pytest-with-#661646b5-a2e7-4b77-a3db-ab585f408793. The tests should ideally make use of the project settings and not hard-code too much, so they also show users how the configuration loading works. Long...

Thanks @yury-fedotov, I noticed the other issue on starter as well. I have now marked this to be done in our next sprint.

Completed in #4368 and https://github.com/kedro-org/kedro-starters/pull/261

I'm bumping the priority on this, because it's been reported again in https://github.com/kedro-org/kedro/issues/4166

Is this at all related to [Move kedro catalog validation schema to kedro-datasets](https://github.com/kedro-org/kedro-plugins/issues/658#top)?

> I'll address @ElenaKhaustova 's comment ☝🏼 but how do I fix the detect-secrets thing? I've addressed the comment and fixed the detect-secrets check as well.