Merel Theisen
Merel Theisen
> Thanks! Updated, and tests are passing now 🎉 I appreciate your help You're welcome and thank you for your contribution! 😄 I've asked some other team members to review....
Thank you for writing up this detailed solution @ElenaKhaustova! This sounds like a strong solution to me. The name changing thing is interesting, but I don't think we should spend...
Hi @ianwhale, thanks so much for your patience with this PR! We're about to launch our new experimental dataset contribution model, which basically means you can contribute datasets that are...
> A couple of thoughts that relate to the topic and we can consider them in future: > > * When we worked with the langchain we found it convenient...
I was still planning on polishing before merging, but then it was already merged. Maybe let the assignee/author complete it next time instead of merging as reviewer?
@michaelsexton I've fixed several issues that weren't related to your changes, but it looks like the tests you added aren't passing currently. I can replicate this locally as well. Do...
> @merelcht Thanks, I should have some time later this week. Is it OK to discuss with you why they might failing if I continue running into them? Hopefully I'll...
Hi @michaelsexton just checking in to see if you're still interested in finishing this PR?
Yes that's what I wrote in the PR description. I didn't want to put the `experimental` directory inside the `kedro_datasets` one because then it just looks like it's one of...
I've updated the implementation and description.