mercurius
mercurius copied to clipboard
mercurius-js
Ambiguous error message 400
After upgrading to version 8.2.1, I'm receiving this error for all syntax errors and also the query depth error.
{
"statusCode": 400,
"code": "MER_ERR_GQL_VALIDATION",
"error": "Bad Request",
"message": "Graphql validation error"
}
This error is obviously not enough for debugging.
After double-checking the issue then it's because of my custom error formatter.
errorFormatter: (result: ExecutionResult) => {
let statusCode = 500;
if (result.errors) {
const firstError = result.errors[0];
if (firstError.extensions) {
statusCode = firstError.extensions.statusCode;
}
}
return {
statusCode,
response: result
};
}
I still can not figure out the issue of that error formatter function. It's only for changing the http status code. But removing it solves this issue.
Which was the last released that worked fine for you?
I think you might want to add some logging to your errorFormatter.
@mcollina It's v7.4.0 . Which sort of logs do you need? I tried to log result.errors and the error is the correct one.
What is the correct error?
Could you please upload an example to reproduce?
There is nothing that strikes me as changing this between v7.4.0 and v7.5.0.
@mcollina I've just created this repo for reproducing the issue. https://github.com/lewispham/mercurius-572 You can follow the readme to reproduce it.
Take a look at https://github.com/mercurius-js/mercurius/blob/037cc1f35c3e4901d3dc219a9ef88b43ac017b0e/lib/errors.js#L63-L94.
You should implement the errorFormatter in a different way if you want all the errors, you do not need to return an Error instance but rather a "plain object" that could be easily serialized. Essentially result is an error.
Take a look at:
app.register(mercurius, {
schema,
resolvers,
errorFormatter: (result) => {
const def = mercurius.defaultErrorFormatter(result)
let statusCode = 500;
if (result.errors) {
const firstError = result.errors[0];
if (firstError.extensions) {
statusCode = firstError.extensions.statusCode;
}
}
const res = {
statusCode,
response: result
};
console.log(JSON.stringify(def))
console.log(JSON.stringify(res))
return JSON.parse(JSON.stringify(res))
}
})
It works for me, but the current version requires an extra context arguments. This issue should be solved but I think we need to document this in the errorFormatter section.
import mercurius from 'mercurius';
const { defaultErrorFormatter } = mercurius;
fastify.register(mercurius, {
schema,
errorFormatter: (result, ctx) => {
const def = defaultErrorFormatter(result, ctx);
return {
statusCode: def.statusCode || 500,
response: def.response,
};
},
});
