RxReduxK icon indicating copy to clipboard operation
RxReduxK copied to clipboard

Migration to RxJava3

Open KeithYokoma opened this issue 5 years ago • 3 comments

Migration Note: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0

KeithYokoma avatar Feb 18 '20 09:02 KeithYokoma

Codecov Report

Merging #29 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     98.18%   98.18%           
  Complexity        8        8           
=========================================
  Files             7        7           
  Lines           330      330           
  Branches         14       14           
=========================================
  Hits            324      324           
  Misses            1        1           
  Partials          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cbd11b...887f8e6. Read the comment docs.

hirak avatar Feb 18 '20 09:02 hirak

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     98.18%   98.18%           
  Complexity        8        8           
=========================================
  Files             7        7           
  Lines           330      330           
  Branches         14       14           
=========================================
  Hits            324      324           
  Misses            1        1           
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
...c/test/java/com/mercari/rxredux/MultiThreadTest.kt 94.87% <ø> (ø) 2 <0> (ø) :arrow_down:
...redux/src/main/java/com/mercari/rxredux/RxRedux.kt 96.55% <ø> (ø) 0 <0> (ø) :arrow_down:
...x/src/test/java/com/mercari/rxredux/RxReduxTest.kt 99.44% <100%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cbd11b...887f8e6. Read the comment docs.

codecov-io avatar Feb 18 '20 09:02 codecov-io

Looks golden to me!

Btw, on the side note since the introduction of DisposableContainer or CompositeDisposable, I think we should improve this API surface

override fun dispatch(vararg actions: Observable<out A>): List<Disposable>

to

override fun dispatch(vararg actions: Observable<out A>): [DisposableContainer | CompositeDisposable]

Since we are about to update this into the new version (I think it has been battle-tested in Merpay long enough to promote RxRedux to version 1.0.0), I might be a good time to rethink the API surface a bit.

kittinunf avatar Feb 19 '20 15:02 kittinunf